[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: bubblemon (updated package)

Hi Adam,

I won't sponsor your package, as I'm not a GNOME user, so I'm not really qualified (BTW, did you try to contact your previous sponsor?), but here's my quick review:

* Adam Sjøgren <asjo@koldfront.dk>, 2011-05-14, 23:28:
I am looking for a sponsor for the new version 2.0.16-1 of my package "bubblemon" (new upstream version).

It builds this binary package:
bubblemon  - Bubbling Load Monitoring GNOME Applet

The package appears to be lintian clean (there is a single warning about the sh locale translation).

If you enable displaying experimental tags, there is one more:

X: bubblemon: duplicate-files usr/share/doc/bubblemon/NEWS.gz usr/share/doc/bubblemon/changelog.gz

...which should be trivial to fix.

The one you mentioned is:

W: bubblemon: unknown-locale-code sh

This one is tad harder. If I understand it correctly, "sh" is a deprecated language code for Serbo-Croatian. You could install this language file as "sr@latin", "hr", or both. (I hope there's at least one -mentors@ reader from Serbia or Croatia who'll correct me if I'm talking nonsense.)

Looking at your changelog:
- Changes to debian/control and debian/copyright are not documented.
- The item about new upstream release could be improved a bit. "New upstream release. (Closes: #567423, #625314)" could make people think that there were two bugs requesting a new upstream release... which is obviously not the case here. How about being more explicit? E.g. you could use something like this:

| * New upstream release.
|   + Update Portugese translation (closes: #567423). Thanks to Américo
|     Monteiro for the patch.
|   + Fix FTBFS with GCC 4.6 (closes: #625314). Thanks to Matthias Klose
|     for the bug report.

Jakub Wilk

Reply to: