[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: mpg321 (updated package, 3rd try)



On Wed, Apr 20, 2011 at 08:39:58PM +0300, Nanakos Chrysostomos wrote:
> On Wed, Apr 20, 2011 at 07:35:07PM +0200, Sandro Tosi wrote:
> > On Wed, Apr 20, 2011 at 19:12, Nanakos Chrysostomos
> > <nanakos@wired-net.gr> wrote:

> > > Another DD has told me in the past that I had to split my patches in order for him
> > > to accept my package and I should always work in that way for my packages to be accepted.
> > 
> > Well, I don't know if it was just a matter of personal taste of that
> > DD, but it's not a requirement. You should provide a single patch for
> > a single change, but it's not restricting the patch to touch only one
> > file. So, in the example of -K, if the addition of it modifies 5
> > files, it's perfectly fine (and it is *the* standard way) to provide a
> > single patch with all the diffs in it.
> 
> I had the same perception as you on the issue but as I said before I had been told
> to follow these instructions. Anyway, your help from now on is precious because I can
> handle in a much better way future patches and versions of my packages.

Just in case this has been me, I hope I wrote something about one patch
per *issue* you try to fix and not one patch per changed file.

Sven
-- 
And I don't know much, but I do know this:
With a golden heart comes a rebel fist.
     [ Streetlight Manifesto - Here's To Life ]


Reply to: