Re: RFS: gnome-icon-theme-faenza
Le samedi 19 mars 2011 à 19:59:52 (+0100 CET), Adnan Hodzic a écrit :
> On Sat, Mar 19, 2011 at 8:30 AM, Julien Valroff <julien@debian.org> wrote:
> > Hi,
> >
> > Le vendredi 18 mars 2011 à 22:54:48 (+0100 CET), Adnan Hodzic a écrit :
> >> > On Fri, Mar 18, 2011 at 8:47 PM, Adam Borowski <kilobyte@angband.pl> wrote:
> >> > The icon for the icon theme itself is missing or invalid -- I get the Gnome
> >> > logo instead of a "directory" icon.
> >>
> >> Fixed(?)
> >
> > Still the same issue (this is in gnome-appearance-properties, in the
> > icons tab).
>
> Ah, now I see what's the issue is. Ok, in package I just re-uploaded I
> added "preinst" and "postinst" which solves this problem.
>
> In "preinst" I forced removal of previous installation, which in my
> case worked and gave me the look of new icons. It was easier for me
> this way, instead of my previous try with dpkg-divert
You don't have to take care of previous installations as this package is not
(yet) part of Debian. You have also done it the wrong way as the code added
to preinst will be run unconditionally, be it a first install or a package
upgrade.
But most importantly, *never* modify a user home directory. In that case, you
remove files in /root or any arbitrary user home in case a user uses sudo
and preserves $HOME:
% sudo echo $HOME
/home/julien
> "postinst" takes cares of the "GNOME" logo problem.
Why not simply use dh_link?
> > Your copyright file is yet to be improved to fulfill DEP5 requirements.
> >
> > Also, you state the icons are licensed under the GPL-3+ but the short name
> > is GPL and I cannot find where you have found they could be distributed
> > under a later version og the GPL. If you had this from upstream in an email,
> > quote it in the copyright file.
>
> Ok, I moved all back to GPL. Even if this represents a problem I could
> get upstram to quote it under GPL3 as he seems as a very good
> cooperator and is eager to see Faenza in Debian.
There is a misunderstanding.
What I meant is that the COPYING file shipped in the tarball states that the
theme is distributed under the GPL-3 but your original copyright file stated
GPL version 3 *or any later version*, while, at the same time, the license
shortname was "GPL" (should have been GPL-3+ to match the following license
paragraph).
More over, your copyright still doesn't fully respect the DEP5 spec:
% config-edit -application dpkg-copyright -ui none
File of type has a syntax error in configuration file:
DpkgSyntax error: Invalid line 42 (missing ':' ?) : Faenza Icon Theme is licensed under the GPL.
> > I also wonder whether it wouldn't be better to split the various themes
> > in 3 different packages given the size of the unique package (13M). What
> > do you think?
>
> I agree with what Adam said on this one:
OK, that was just a proposal, I'm fine with a single package.
BTW, I hadn't paid attention that some icons are shared between the 3 themes
using symlinks (11,804 symlinks for 5,212 filesi, 4,443 of them being in
Faenza, ie. both other themes overhead is inferior to 800 files…).
You should also fix the following lintian warnings:
I: gnome-icon-theme-faenza source: debian-watch-file-is-missing
W: gnome-icon-theme-faenza: executable-not-elf-or-script ./usr/share/icons/Faenza/emblems/24/emblem-important.icon
W: gnome-icon-theme-faenza: executable-not-elf-or-script ./usr/share/icons/Faenza-Dark/index.theme
W: gnome-icon-theme-faenza: executable-not-elf-or-script ./usr/share/icons/Faenza-Darkest/index.theme
W: gnome-icon-theme-faenza: executable-not-elf-or-script ./usr/share/icons/Faenza/emblems/22/emblem-important.icon
W: gnome-icon-theme-faenza: executable-not-elf-or-script ./usr/share/icons/Faenza/emblems/48/emblem-important.icon
W: gnome-icon-theme-faenza: executable-not-elf-or-script ./usr/share/icons/Faenza/emblems/scalable/emblem-important.icon
W: gnome-icon-theme-faenza: executable-not-elf-or-script ./usr/share/icons/Faenza/emblems/16/emblem-important.icon
W: gnome-icon-theme-faenza: executable-not-elf-or-script ./usr/share/icons/Faenza/emblems/32/emblem-important.icon
W: gnome-icon-theme-faenza: executable-not-elf-or-script ./usr/share/icons/Faenza/index.theme
Shouldn't the package depend on librsvg2-common for .svg files?
Why do you buil-depend on debhelper >= 7.0.50~? You don't use any dh_overrides
hence >= 7 should be enough.
Your VCS-* fields seem to be wrong - please fix them or create the git
repository in collab-maint before the package gets uploaded.
Cheers,
Julien
--
.''`. Julien Valroff ~ <julien@kirya.net> ~ <julien@debian.org>
: :' : Debian Developer & Free software contributor
`. `'` http://www.kirya.net/
`- 4096R/ E1D8 5796 8214 4687 E416 948C 859F EF67 258E 26B1
Reply to: