[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ITR: robocut (driver for consumer GRAPHTEC cutting plotters like Silhouette SD and craftROBO)

On 2010-12-20 04:10, David Bremner wrote:
> On Sun, 19 Dec 2010 17:54:03 -0400, David Bremner <bremner@debian.org> wrote:
>> I intend to review, and all going well sponsor this.
> Uploaded. Some comments for the next upload:
Thank you for helping me.
> - It wasn't clear to me how the Debian source package is produced from
>   the git repository. Perhaps you could document this in
>   debian/README.source
I'm generating the tar.gz file via qmake; make; make dist - please tell
me if I need to create this readme file in this case or not?
(From debian-policy 4.14 I don't think so, but I'm still learning)

> - Can you talk to Tim about re-generating the moc/qrc files at package
>   build time (either don't distribute them, or delete them in the clean
>   step)? Unless there are good reasons not to do this, it will make it
>   clear that the package really supplies all the needed source (as you
>   tested by deleting them and running make).
I will look into this, I'm hoping there is a qmake configuration option
to solve this.

I did look into git archive and dpgk- source options that were suggested
on irc, however I guess if users compile from scratch on non Debian
systems this source packaging with make dist could make it easier...

Markus Schulz

Reply to: