[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ITR: robocut (driver for consumer GRAPHTEC cutting plotters like Silhouette SD and craftROBO)



On Sun, 19 Dec 2010 17:54:03 -0400, David Bremner <bremner@debian.org> wrote:
> 
> I intend to review, and all going well sponsor this.
> 

Uploaded. Some comments for the next upload:

- Can you talk to Tim about re-generating the moc/qrc files at package
  build time (either don't distribute them, or delete them in the clean
  step)? Unless there are good reasons not to do this, it will make it
  clear that the package really supplies all the needed source (as you
  tested by deleting them and running make).

- It wasn't clear to me how the Debian source package is produced from
  the git repository. Perhaps you could document this in
  debian/README.source

Thanks for your contribution to Debian

d

Attachment: pgpZMmmMMG43i.pgp
Description: PGP signature


Reply to: