Re: RFS: teapot
On Fri, Dec 10, 2010 at 7:45 PM, Yuri D'Elia <wavexx@users.sf.net> wrote:
> I am looking for a sponsor for my package "teapot".
Here is a review:
debian/patches/debian-changes-2.2.0-1 makes me think your debian/rules
is not cleaning up properly.
Please send your patches upstream if appropriate or reimplement them
so they are appropriate.
Until they are accepted upstream, please add DEP-3 headers to your patches.
http://dep.debian.net/deps/dep3/
Please send your manual page upstream.
Why is override_dh_auto_configure needed? It looks like
dh_auto_configure supports cmake and passes the right params.
You might want to wrap the build-depends line since it is very long.
Please ask upstream to split the list of changes in README out into a NEWS file.
You should use the same license as upstream for the Debian packaging,
so upstream can use it. Please consider adopting GPLv3+ instead of
GPLv3.
lintian complaints about the source package:
I: teapot source: duplicate-short-description teapot teapot-gui
I: teapot source: quilt-patch-missing-description 10-shared-fltk.patch
I: teapot source: quilt-patch-missing-description 20-manual-path.patch
--
bye,
pabs
http://wiki.debian.org/PaulWise
http://bonedaddy.net/pabs3/
Reply to: