[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: aqemu (update)

Hello gregoa,

On Sat, Nov 20, 2010 at 22:50, gregor herrmann <gregoa@debian.org> wrote:
> On Sat, 20 Nov 2010 19:16:26 +0100, Ignace Mouzannar wrote:
>> I am looking for a sponsor for the new version 0.8.0-1
>> of my package "aqemu".
> A quick look:
> - debian/rules: you don't need the override_dh_auto_clean, if you put
>  the files-to-be-deleted into debian/clean dh_clean picks them up
>  (note that this does not work with directories yet)

Ooh, excellent. The override was removed and the clean file added.

> - debian/copyright: the main copyright is "2008-2010" now,
>  Embedded_Display/remoteview.cpp also needs 2010 for Andrey Rijov
>  (I haven't checked the other notices)

I have updated the debian/copyright format, added the new copyrights
mentions, and removed copyrights of files that are no longer
distributed upstream.

> - debian/README.source should be removed (points to dpatch usage)
> - same with debian/aqemu.docs (which was wrong even with dpatch)

I have removed both of these files.

> - .postinst and .postrm: I think the debhelper token is enough and
>  you don't need the manual calls to update-menu. At the moment the
>  code is there twice in the binary package. --
>  Or maybe you can delete .postinst and .postrm completely, dh_menu
>  probably takes care of everything. Please try it out, I don't want
>  to build the package again on my old machine :)

You are absolutely right. I rebuilt the package without the postinst
and postrm files, and the update-menu was automatically added by
| $ cat postrm
| #!/bin/sh
| set -e
| # Automatically added by dh_installmenu
| if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
| # End automatically added section
This too has been corrected.

A new version has been uploaded on m.d.n [1] correcting the above
issues you have spotted. :)

Thank you very much taking the time to review my package.

 Ignace M

[1] - URL: http://mentors.debian.net/debian/pool/main/a/aqemu
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/a/aqemu/aqemu_0.8.0-1.dsc

Reply to: