Re: RFS: dalle
El jue, 04-11-2010 a las 10:11 +0100, Mònica escribió:
> On Wednesday 03 November 2010 at 23:23:54, Alberto Fernández wrote:
> > El mié, 03-11-2010 a las 10:55 +0100, Mònica escribió:
> >
> > Thanks very much for your help.
> > I've just uploaded a fixed package with your suggestions.
>
> :-)
>
> > > I'm not a DD, but here's my review for your package:
> > > The review is about the Debian package source, I haven't reviewed how the program works.
> > >
> > > * Lintian: I: dalle source: missing-debian-source-format
> > > - You shopuld have the file debian/source/format indicating your package source format.
> > > Now, it's recommended switching to "3.0 (quilt)".
> >
> > I don't know why lintian didn't warn this to me .... ?
>
> lintian -i -I --show-overrides package
>
> If you use debuild you can use its configuration file .devscripts:
> DEBUILD_LINTIAN=yes
> DEBUILD_LINTIAN_OPTS="-i -I --show-overrides"
I was using dpkg-buildpackage and calling lintian manually with "-i -v
--pedantic". I've switched to debbuild.
>
> Now you have another lintian warning:
> I: dalle source: debian-watch-file-is-missing
>
> So, you should add a watch file.
>
Fixed!
> > > * debian/rules:
> > > - Delete comment lines that are not your own comments like "Sample debian/rules...".
> > > - You can install files with the file debian/install, so you can delete "cp" lines and your
> > > debian/rules will be more simple.
> > > - You can install manpages with files dalle.manpages or putting them in debian directory
> > > with namepacke.1 (or the corresponding number)
> >
> > Rules cleaned :)
>
> In case you don't know it, you can make packages with "dh $@". Your debian/rules would be sitll nore simple. You can read about it in the "Debian New Maintainers' Guide" [1].
I've to learn about it. Next week.
>
> > >
> > > * debian/control
> > > - Some spelling mistakes in the long description: splited -> split, Dalle support -> Dalle suports
> >
> > It's my horrible English. I must practice.
>
> Me too :-)
>
> > > I hope my advises help you :-)
> > Thank you.
>
> Not at all! I love helping :-)
>
> > > If any other person from the list see a mistake in my review, "reviews of my review" are welcomed!
> > >
> >
> > Is there someone with experience packaging CLI apps to review the
> > package?
>
> Cheers.
>
>
> [1] http://www.debian.org/doc/maint-guide/
>
Reply to: