Re: RFS: dhcp-probe, another try to request with a lot of update
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Michal Čihař a écrit :
> Hi
>
> Most of things were already answered in Matthews reply, I only react on
> missing things.
>
> Dne Thu, 27 Nov 2008 22:14:56 +0100
> Laurent Guignard <lguignard.debian@gmail.com> napsal(a):
>
>>> - debian/rules:
>>>
>>> - rm -f can not fail, so you can strip some useless test commands
>>> - "test ! -f Makefile || ./debian/rules config.status" - dependencies
>>> in makefile should ensure this
>> Yes sure for "rm -f" and its possible fail.
>>
>> I thought it was a cleaner method to test the file exists before running
>> a command on, but may be i am wrong ?
>
> The test is okay, but why do you invoke debian/rules? If you need
> config.status to be up to date, just make it a dependency of rule where
> you need it.
>
>
The main difference i can see, is that someone that download the source
package could manualy run a ./configure with his own options and
generate his own Makefile that could be used after to generate a
specific package (may be with a special path...).
If i put a dependency on the install rule, this possibility disappear
and all dpkg-buildpackage will build the same package.
May be this freedom to the system administrator that build the package
hasn't to be there ?
Have a good week-end
Best regards
- --
Laurent Guignard, Registered as user #301590 with the Linux Counter
Site : http://www.famille-guignard.org
Blog : http://blog.famille-guignard.org
Projet : http://sicontact.sourceforge.net
GULL de Villefranche sur Saône : http://www.cagull.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFJMTeFjcKpXFc/7oYRAubAAJ44zDH22cHtReD2NhzyT8Lr/oZqUACbBQ+S
wp+vg5Z3ye0/YYEb74F1BNc=
=X+G5
-----END PGP SIGNATURE-----
Reply to: