Re: RFS: webcpp (adoption, bugfix and standards/dh7)
Hello Jonathan,
thanks a lot for the fast reply.
On Wed, Nov 26, 2008 at 15:21, Jonathan Wiltshire
<debian@jwiltshire.org.uk> wrote:
> On Wed, Nov 26, 2008 at 11:00:52AM +0100, Sandro Tosi wrote:
>> - no need to "[ ! -f configure-stamp ] || ..." since -stamp targets
>> are only executed is -stamp file is missing
>> - -stamp file are sually touched with "touch $@" (less spelling
>> problem and chars to digit ;) )
>
> Aha, still learning about dh7!
well, that's notions about makefiles and not strictly about dh7 :)
>> debian/README.source
>> - it's missing, but it's needed by 3.8.0, to explain that you're using
>> a patch system.
>
> Ok, written and included.
Even a simpler one where enough :) for example, simply saying you're
using dpatch and the info about dpatch are in /usr/share/doc/dpatch
(similar to what I usually write) would be enough.
> The dsc is at:
> http://mentors.debian.net/debian/pool/main/w/webcpp/webcpp_0.8.4-7.dsc
ehm, I personally like to have all the changes in the revision =
"current revision in debian"+1, so -6, and you have the opportunity to
"fix" this since.... your package FTBFS if build twice in a row. what
does this mean? take your source pacakge and uncompress it, then exec
"debuild -us -uc && debuild -us -uc", the second execution will fail
with
dpatch deapply-all
reverting patch 05_makefile_docdir from ./ ... ok.
reverting patch 04_offbyone from ./ ... ok.
reverting patch 03_bashism_fix from ./ ... ok.
reverting patch 02_gcc43_patch from ./ ... ok.
reverting patch 01_gcc41_patch from ./ ... ok.
rm -rf patch-stamp patch-stampT debian/patched
rm -f config.sub config.guess
[ ! -f Makefile ] || /usr/bin/make distclean
make[1]: Entering directory `/home/morph/deb/sponsorship/webcpp-0.8.4'
cd . && /bin/sh ./config.status Makefile
config.status: error: invalid argument: Makefile
make[1]: *** [Makefile] Error 1
make[1]: Leaving directory `/home/morph/deb/sponsorship/webcpp-0.8.4'
make: *** [clean] Error 2
dpkg-buildpackage: failure: fakeroot debian/rules clean gave error exit status 2
debuild: fatal error at line 1319:
dpkg-buildpackage -rfakeroot -D -us -uc failed
could you please give it a look and fix it?
Once ok, please "merge" all the changes in the -6 entry, and upload
again; don't hesitate to ask in case of any question.
Thanks,
--
Sandro Tosi (aka morph, Morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
Reply to: