[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: webcpp (adoption, bugfix and standards/dh7)



On Wed, Nov 26, 2008 at 11:00:52AM +0100, Sandro Tosi wrote:
> debian/compat
> - has 5 while you declare versioned build-dep on debhelper >=7
> debian/rules
> - don't export DH_VERBOSE
> - you can remove the commented header

Fixed

> - no need to "[ ! -f configure-stamp ] || ..." since -stamp targets
> are only executed is -stamp file is missing
> - -stamp file are sually touched with "touch $@" (less spelling
> problem and chars to digit ;) )

Aha, still learning about dh7!

> - instead of "ln -s" you can use dh_link and its file to create symlinks
> - you may "play" a bit with Makefile (patching it) instead of install
> doc.html in a dir and then move it into Debian right place

I've patched it in 05_makefile_docdir

> debian/README.source
> - it's missing, but it's needed by 3.8.0, to explain that you're using
> a patch system.

Ok, written and included.

The dsc is at:
http://mentors.debian.net/debian/pool/main/w/webcpp/webcpp_0.8.4-7.dsc

Thanks for your comments.



-- 
Jonathan Wiltshire

Attachment: signature.asc
Description: Digital signature


Reply to: