Re: RFS: mod-spamhaus
On Mon, Nov 3, 2008 at 2:15 AM, Giuseppe Iuculano <giuseppe@iuculano.it> wrote:
> http://mentors.debian.net/debian/pool/main/m/mod-spamhaus/mod-spamhaus_0.7-1.dsc
Some more things:
Your package description needs some grammar fixes, please ask for a
review on debian-l10n-english.
You don't specify any specific version the GPL for your packaging, was
that intentional?
Upstream's license grant is unclear about the GPL version; "either
version 3 of the License." doesn't make sense.
The ReadMe.txt file only contains information present elsewhere in the
package (debian/copyright, debian/control, debian/rules,
debian/postinst, debian/conf), I don't think you need to ship it in
the .deb.
Other than that (and without having tested it) the package looks good.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: