Re: RFS: mod-spamhaus

["Paul Wise" <pabs@debian.org>]

On Sun, Oct 26, 2008 at 5:54 AM, Giuseppe Iuculano <giuseppe@iuculano.it> wrote:

> http://mentors.debian.net/debian/pool/main/m/mod-spamhaus/mod-spamhaus_0.6-1.dsc

A review of your source package:

debian/watch should use the standard sf qa redirector, please read the
uscan manual page.

The upstream source does not contain any copyright information, you
might want to ask them to fix that.

There is a new upstream version available (0.7).

Please ask upstream to fix the compiler warnings:

src/mod_spamhaus.c: In function 'core':
src/mod_spamhaus.c:256: warning: assignment makes pointer from integer
without a cast
src/mod_spamhaus.c: In function 'num_cached_ip':
src/mod_spamhaus.c:358: warning: passing argument 1 of 'atoi' makes
pointer from integer without a cast
src/mod_spamhaus.c: At top level:
src/mod_spamhaus.c:367: warning: initialization from incompatible pointer type
src/mod_spamhaus.c:368: warning: initialization from incompatible pointer type
src/mod_spamhaus.c:369: warning: initialization from incompatible pointer type
src/mod_spamhaus.c:370: warning: initialization from incompatible pointer type

-- 
bye,
pabs

http://wiki.debian.org/PaulWise