On Fri, 26 Sep 2008 14:55:44 +0200, Cristian Greco wrote:
> It builds these binary packages:
> pacpl - a multi-purpose audio converter/ripper/tagger script
>
> Long Description:
> Perl Audio Converter is a tool for converting multiple audio types from one
> format to another using various external encoders/decoders.
Looks nice!
> I would be glad if someone reviewed and uploaded this package for me.
Just a few remarks:
* I would not install (i.e. remove in debian/rules)
/etc/pacpl/modules/{,sample.m}
* debian/copyright:
- the upstream license should be GPL-3+ (and not GPL-3)
- "Files: *" should be before "Files: debian/*", if I understand
the section about "Match order" correctly on
http://wiki.debian.org/Proposals/CopyrightFormat
- any specific reason why you license debian/* under GPL-2+ and not
GPL-3+ like upstream?
Otherwise the package looks fine after a quick glance over it.
Cheers,
gregor
--
.''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4
: :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/
`. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
`- NP: Queen: All God's People
Attachment:
signature.asc
Description: Digital signature