Re: RFS: tkgate (updated package)
On Sun, May 25, 2008 at 12:43:19PM +0200, Vincent Bernat wrote:
> What about bug #474496? Is it fixed?
Yes it is indeed. I will put that in the changelog.
> Is the fact that tkgate is using Tcl/Tk important enough to be included
> in the short description? For an end-user software, this is usually not
> the case: don't say that a software is written in Python or is using QT
> as toolkit.
Ok, fixed.
> About your lintian override for tree.tcl, you can also patch the file to
> remove the she-bang. But a lintian override is valid for me.
I added a patch for tree.tcl to remove the she-bang.
> uscan does not find the version you are packaging. You should update it
> to let him find the correction version. I think that you will have to
> use mangling options too.
Done. Please check it
> The package looks fine otherwise.
Thanks a lot for the review, I uploaded the new package:
http://mentors.debian.net/debian/pool/main/t/tkgate/tkgate_2.0~a11.dfsg.1-1.dsc
--
أحمد المحمودي (Ahmed El-Mahmoudy)
Digital design engineer
SySDSoft, Inc.
GPG KeyID: 0x9DCA0B27 (@ subkeys.pgp.net)
GPG Fingerprint: 087D 3767 8CAC 65B1 8F6C 156E D325 C3C8 9DCA 0B27
Reply to: