Re: RFS: parcellite

[Andrew <a.starr.b@gmail.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On Sun, May 11, 2008 at 4:13 AM, Vincent Bernat  wrote:
> OoO En cette nuit striée d'éclairs  du dimanche 11 mai 2008, vers 02:40,
>  Andrew  disait:
>
>  I don't remember if your  original package modified files from upstream,
>  but you  should prefer the  use of a  patch management system.  quilt is
>  easy to use with debhelper. For  very simple change, you could also just
>  use  sed in  debian/rules (for  example  to remove  encoding in  desktop
>  files).

My initial packaging did not touch the upstream source. All four lines
changed from the source were in response lintian warnings (encoding in
upstream desktop file and "-"s in the upstream  man page) run on the
.change_i383 file brought up in review. I didn't think it was
necessary to add a build dep (ie quilt or dpatch) over a lintian
warning. I'll fix this.

>  You state that eggaccelerator.h is  GPL2+. However, this is LGPL2+.  Use
>  licensecheck to help you spot those copyright issues.

That was a typo when converting to the machine readable format. The
license text still correctly says LGPL2+. I'll fix this as well.


Thanks again for the review.  I'll upload a new version soon.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIJrFLL4k+fGKG+20RAovWAJ9kB8/sqLgDokHWPogVIv5QNzHblwCggNqA
a4hkS15VW9BfE6Seb3ePh5E=
=3+NA
-----END PGP SIGNATURE-----