OoO Pendant le journal télévisé du lundi 05 mai 2008, vers 20:13, Andrew <a.starr.b@gmail.com> disait: > I am looking for a sponsor for my package "parcellite". It's a light > weight gtk+ clipboard manager not yet in Debian. It would also be my > first package in Debian, so I would appreciate a review. Hi Andrew! debian/compat contains 6 but you depend on debhelper (>= 5) in debian/control. Your debian/copyright is incomplete. It misses for example src/keybinder.*. You may also convert it to a machine-readable one since it is almost in the correct form: http://wiki.debian.org/Proposals/CopyrightFormat You can clean up a bit debian/rules by removing comments stating that it is a sample file. You may also want to remove unused dh_* call (dh_link for example). There are two lintian warnings that you should fix: I: parcellite: desktop-entry-contains-encoding-key /usr/share/applications/parcellite.desktop:2 Encoding I: parcellite: hyphen-used-as-minus-sign usr/share/man/man1/parcellite.1.gz:27 Use "lintian -vIi parcellite_0.7-1_amd64.changes" to get the complete explanation about this one. You close the ITP bug with an unusual "Closes: Bug#XXXXX". It seems this is valid but I think it might be better to stick to "Closes: #XXXXX". Otherwise, your package seems fine. -- A FIRE DRILL DOES NOT DEMAND A FIRE A FIRE DRILL DOES NOT DEMAND A FIRE A FIRE DRILL DOES NOT DEMAND A FIRE -+- Bart Simpson on chalkboard in episode 4F16
Attachment:
pgpfgy5FJJzi6.pgp
Description: PGP signature