[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ladr and prover9-manual (updated package)



On Fri, Jan 18, 2008 at 09:02:02PM +0100, David Bremner wrote:
> 1) lintian will now complain about standards version 3.7.2 as being
>    old

Fixed.

> 
> 2) I didn't really understand why you use 
>    cp -a bin/* debian/tmp/usr/bin
> 
> instead of dh_install or something.

The packages now copy their binaries directly from bin using dh_install.
> 
>    libtool --mode=install cp -a ladr/libladr.la   `pwd`/debian/tmp/usr/lib
> 
> also struck me as being a pretty opaque way to install a library.
> Your milage may vary.

I did this because libtool needs to copy the library to the installation
directory itself in the correct (platform-specific) way.  Note that
most packages that install libraries using upstream's makefile would do
exactly the same thing.

> 
> 3) Your man pages could be improved. I guess you know that, since at
> least you have stubs.  You might find the script help2man helpful,
>  Something like 
>    help2man -h-help rewriter > rewriter.1 
> gets you a file that requires only light editing.

I now have man pages for 7 more of the more commonly used apps.
> 
> 4) I think some simple examples in /usr/share/doc would be motivating
> for someone trying the package out (in particular sponsors).

There's already an example for prover9 and two for mace4 in
/usr/share/doc/{prover9,mace4}/examples from the source package in
{prover9,mace4}.examples .

Thanks,
-- 
Peter

Attachment: signature.asc
Description: Digital signature


Reply to: