Re: RFS: ed2k-hash
* David Paleino <d.paleino@gmail.com> [2007-04-20 19:05:05 +0200]:
> > Some notes on your package:
>
> I didn't put any Makefile.* there. Maybe I just made some mistaken "cp". :-P
Also, there is a "debian" dir in the upstream package on sf.net. Even if you
were the upstream it would still a bad idea to ship "debian" in the original
tarball, but since you are not upstream then repackaging the orig.tar.gz to
remove that debian dir makes sense in this case.
> > Why do you ship /usr/share/doc/ed2k-hash/Makefile.in.gz in your package?
>
> Uh?!
See the output of $dpkg -L ed2k-hash:
/.
/usr
/usr/bin
/usr/bin/ed2k-hash-gui
/usr/bin/ed2k-hash
/usr/share
/usr/share/doc
/usr/share/doc/ed2k-hash
/usr/share/doc/ed2k-hash/changelog.gz
/usr/share/doc/ed2k-hash/NEWS.gz
/usr/share/doc/ed2k-hash/README
/usr/share/doc/ed2k-hash/TODO
/usr/share/doc/ed2k-hash/index-1.html
/usr/share/doc/ed2k-hash/index-2.html
/usr/share/doc/ed2k-hash/index-3.html
/usr/share/doc/ed2k-hash/index-4.html
/usr/share/doc/ed2k-hash/index-5.html
/usr/share/doc/ed2k-hash/index-6.html
/usr/share/doc/ed2k-hash/index.html
/usr/share/doc/ed2k-hash/Makefile.am
/usr/share/doc/ed2k-hash/copyright
/usr/share/doc/ed2k-hash/changelog.Debian.gz
/usr/share/doc/ed2k-hash/Makefile.in.gz
/usr/share/man
/usr/share/man/man1
/usr/share/man/man1/ed2k-hash.1.gz
/usr/share/man/man1/ed2k-hash-gui.1.gz
> On my current build, I don't have any Makefile.in.gz in docs. I'm gonna
> check it.
>
> > Remove the commented lines from your debian/rules to reduce clutter.
>
> Sure, I just forgot to do it. (that's why mentors exist :-P)
>
> > You should have Build-Depends on libfltk1.1-dev in order to have the GUI part
> > built and remove the text about it from debian/control i.e. "
> > "
> > .
> > By installing the fltk1.1 library, you'll have a GUI too.
> > "
> >
> > This should get you started.
>
> Thank you for your help.
>
> .../me looks for what could've gone wrong...
>
> dpkg-source: building ed2k-hash in ed2k-hash_0.4.0-1.diff.gz
> ...
> dpkg-source: warning: ignoring deletion of file
> ed2k_hash/docs/en/Makefile.am
> dpkg-source: warning: ignoring deletion of file
> ed2k_hash/docs/en/Makefile.in
> dpkg-source: warning: ignoring deletion of file ed2k_hash/docs/Makefile.am
> dpkg-source: warning: ignoring deletion of file ed2k_hash/docs/Makefile.in
> ...
>
> Any idea on how to get rid of this?
> dpkg-source doesn't consider the deleted files. That implies that the
> diff won't have the "delete patch", so the files I deleted will be in
> the extracted source. But, since I deleted them, it will compile fine on
> my box. Any idea on how to fix this? TIA.
Oh, darn. I started figuring it out and before long had to rework the
packaging a lot mainly due to a seriously screwed up build system from the
upstream. I'm not sure I would bother if I knew what was in store. Anyway,
hours later here is the result:
dget http://debian.tagancha.org/download/ed2k-hash_0.4.0-1.dsc
Take a look. If you agree with my changes and promise to take care of the
beast from now on I can upload your package.
Regards,
Alex.
Reply to: