Re: RFS: meep

[Daniel Baumann <daniel@debian.org>]

Daniel Baumann wrote:
> ok, then let's first upload all those build-depends (seperate mail)...

here we go for harminv:

  * ${misc:Depends} is useless here
  * remove the following line from the dpatch:

---snipp---
## All lines beginning with `## DP:' are a description of the patch.
---snapp---

  * debian/rules:
    - do not use two empty lines as seperator, one is just enough.
    - seperatation into build-arch and build-indep is overengineered,
      you do not have indep packages.
      same goes for install-arch/install-indep. look at lwp from sid for
      an example on how to keep rules simple (also *.install could be
      done simplier by using wildcards, can be seen in lwp too).
    - i would recommend to just use the dpatch include as i wrote for
      meep.
    - you install into debian/tmpinst. it's best practise to install
      into debian/tmp. do you insist to be 'different'?

rest is good, if you fix above things, i'm happy to sponsor it.

here we go for libctl:

  * if you adopt the package, you should also change the maintainer
    filed ;)
  * the common order of fields in control is:
    Package / Section / Architecture / Depends / Conflicts / Replaces /
    Suggests / Replaces / Provides. Keep it at least in the same control
    file consistent.
  * ${misc:Depends} is not used here too.
  * wrap the long description after 80 chars a line, not earlier.
  * replaces 'Copyright:' with 'License:' in debian/copyright

rest is good, if you fix above things, i'm happy to sponsor it.

if you updated these two packages, i look again at meep.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/