Re: RFS: meep

[Daniel Baumann <daniel@debian.org>]

Loic Le Guyader wrote:
> The package is lintian clean. But I have problem with the -dev packages. They
> are empty and I don't understand why.

it wasn't empty here.

> I would be glad if someone can check and upload this package for me.

please fix the following things:

  * remove the useless empty line at the end of changelog.
  * write "libctl-dev (>= 3.0.0)" and not "libctl-dev(>= 3.0.0)".
  * can't find the build-dep libharminv-dev, where did you get that
    from?
  * this is wrong:

---snipp---
 URL: http://ab-initio.mit.edu/wiki/index.php/Meep
---snapp---

    and this is right:

---snipp---
  Homepage: http://ab-initio.mit.edu/wiki/index.php/Meep
---snapp---

    note the *two* leading spaces.

  * debian/docs should be prefixed with the package name where it
    belongs to (not using a pacakge prefix in the filename results
    in having it assigned to the first found package in debian/control).

  * remove the commented useless things from the manpage.

  * this is ugly:

---snip---
#! /bin/sh /usr/share/dpatch/dpatch-run
---snapp---

    and this is beautiful:

---snipp---
#!/bin/sh /usr/share/dpatch/dpatch-run
---snapp---

  * fix the patch author information in all dpatches. it should be:

---snip---
## 01_some-patch.dpatch by Example Developer <developer@example.com>
---snapp---

  * debian/rules:
    - remove the commented things at the beginning
    - use 'patch-stamp', not 'patch' for the dpatch target.
    - if you include dpatch.make, you don't need to define the dpatch
      targes, look at cdrdao on how to make it right.
    - DH_VERBOSE=1 should not be default.
    - this is not needed:

---snip---
clean: clean-patched unpatch
clean-patched:
---snapp---

       just do this:

---snipp---
clean: unpatch
---snapp---

if you fix above things, I'll upload the package.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/