Re: Subject: RFS: mantis (updated package)

[Daniel Baumann <daniel@debian.org>]

Patrick Schönfeld wrote:
> http://just-imho.net/~schoenfeld/debian-devel/mantis_1.0.6-1.dsc

you're using patches, nevertheless you're modifying core/checkin.php, is
this intentional?

  * NEWS: don't use two (or more) empty lines as seperator, one
    is just enough.

  * README.LDAP: remove the ueseless empty line at the end of the file.

  * changelog: remove the empty lines at the end of the file.

  * This:

---snip---
 Upstream URL: http://www.mantisbt.org
---snap---

    should be this:

---snip---
  Homepage: http://www.matisbt.org
---snap---

    also note the two leading spaces.

  * This '|apache-perl' should be this '| apache-perl'

  * dirs is useless here.

  * mantis.dirs, mantis.example has a useless empty line at the end.

  * remove the useless commented stuff in watch

  * you're lacking a build-depends on dpatch

  * if you're including the dpatch.make in rules, you can skip the
    definition of patch/unpatch targets. look at 9base for an example.

  * this is ugly:

---snip---
#! /bin/sh -e
---snap---

    this is beautiful:

---snip---
#!/bin/sh -e
---snap---

     in your dpatch headers. Additionally, you may want also fix the
     author information:

     This is ugly:

---snip---
by  <schoenfeld@in-medias-res.com>
---snap---

     This is beautiful:

---snip---
by Patrick Schönfeld <schoenfeld@in-medias-res.com>
---snap---

  * what is debian/patches/DPATCH intended to be for?

if you fix above things, i'll sponsor mantis.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/