Re: Subject: RFS: mantis (updated package)

[Patrick Schönfeld <schoenfeld@in-medias-res.com>]

Hi Daniel,

i have just finished my work on the package. My changes are:

* the ones you mentioned - everything should be okay now
* (re)added a debian/po directory and template files for translators
* Changed Upstream URL to mantisbugtracking.com as Michael told me

Incoming queue of m.d.o is stil stalled. Therefore i uploaded it to my
private webspace again:

- URL: http://just-imho.net/~schoenfeld/debian-devel/mantis
- dget
http://just-imho.net/~schoenfeld/debian-devel/mantis/mantis_1.0.6-1.dsc

Best Regards

Patrick


Daniel Baumann wrote:
> Patrick Schönfeld wrote:
>> http://just-imho.net/~schoenfeld/debian-devel/mantis_1.0.6-1.dsc
> 
> you're using patches, nevertheless you're modifying core/checkin.php, is
> this intentional?
> 
>   * NEWS: don't use two (or more) empty lines as seperator, one
>     is just enough.
> 
>   * README.LDAP: remove the ueseless empty line at the end of the file.
> 
>   * changelog: remove the empty lines at the end of the file.
> 
>   * This:
> 
> ---snip---
>  Upstream URL: http://www.mantisbt.org
> ---snap---
> 
>     should be this:
> 
> ---snip---
>   Homepage: http://www.matisbt.org
> ---snap---
> 
>     also note the two leading spaces.
> 
>   * This '|apache-perl' should be this '| apache-perl'
> 
>   * dirs is useless here.
> 
>   * mantis.dirs, mantis.example has a useless empty line at the end.
> 
>   * remove the useless commented stuff in watch
> 
>   * you're lacking a build-depends on dpatch
> 
>   * if you're including the dpatch.make in rules, you can skip the
>     definition of patch/unpatch targets. look at 9base for an example.
> 
>   * this is ugly:
> 
> ---snip---
> #! /bin/sh -e
> ---snap---
> 
>     this is beautiful:
> 
> ---snip---
> #!/bin/sh -e
> ---snap---
> 
>      in your dpatch headers. Additionally, you may want also fix the
>      author information:
> 
>      This is ugly:
> 
> ---snip---
> by  <schoenfeld@in-medias-res.com>
> ---snap---
> 
>      This is beautiful:
> 
> ---snip---
> by Patrick Schönfeld <schoenfeld@in-medias-res.com>
> ---snap---
> 
>   * what is debian/patches/DPATCH intended to be for?
> 
> if you fix above things, i'll sponsor mantis.
>