Re: RFS: sdljump

[Justin Pryzby <justinpryzby@users.sourceforge.net>]

On Sun, Feb 12, 2006 at 12:42:26PM -0300, Margarita Manterola wrote:
> On 2/12/06, Bas Wijnen <shevek@fmf.nl> wrote:
> 
> > The package can be found at http://pcbcn10.phys.rug.nl/~shevek/sdljump/.
> 
> It's actually at http://pcbcn10.phys.rug.nl/~shevek/debian/sdljump/
> 
> The package is in very good state, it's lintian clean (although linda
> issues a warning).  I have some comments:
> 
> In your debian/rules build-stamp target you do:
>     ACLOCAL="aclocal-1.9 -I /usr/share/autoconf-archive"
> AUTOMAKE=automake-1.9 autoreconf -f -i -s
> 
> And in the clean target, you do:
>     -$(MAKE) maintainer-clean
>     rm -f config.guess config.sub configure depcomp INSTALL install-sh \
>         ltmain.sh missing mkinstalldirs config.log aclocal.m4
>     -find . -name Makefile.in -exec rm {} \;
Sorry to bring up an old thread;

-$(MAKE) clean is considered bad; see #325372: 'lintian: please add
check for careless usage of "make clean" and the like'.

The suggested alternatives are things like

  [ -f ./Makefile ] && $(MAKE) clean

  ifeq (Makefile,$(wildcard Makefile))
    make clean
  endif

  [ ! -f ./Makefile ] || $(MAKE) clean

  set -e; if [ -f Makefile ]; then $(MAKE) distclean; fi;

I don't think the set -e accomplishes anything here, since there is
only one command, but in general it is required.

Justin