Re: RFS - kommando - ITP #336607

[Christoph Haas <haas@debian.org>]

Hi, Sune...

the package looks a lot better now. Thanks for your work. I have just 
uploaded the package.

Some minor things you may want to look at for your next revision:

You change the kommando-0.2/src/kommando.desktop file. You should either 
have the upstream include this change in the next release or use "dpatch". 
If the upstream comes up with a new release you will have to remember 
changing that file again.

Spend some time looking at the debhelper scripts (dh_*). Each of them has a 
man page. And many tasks you do manually in your debian/rules file are 
easier done through debhelper. Example:
"cp debian/kommando.xpm debian/kommando/usr/share/pixmaps/" would look 
nicer if you used "dh_install" for it.

I personally don't like to "make install" into debian/$PACKAGE. I rather 
pick the files I need and use dh_install to copy them into place. At least 
in simpler packages like these which don't contain hundreds of files it's 
easy. But that's a matter of taste.

Thanks for your contribution so far.

 Christoph
-- 
    |\      _,,,---,,_        Famous last words of a sysadmin:
    /,`.-'`'    -.  ;-;;,_    "We'll do the backup tomorrow."
  <|,4-  ) )-,_..;\ (  `'-'
    '---''(_/--'  `-'\_)