On Tue, 2005-10-11 at 18:26 -0400, Jean-Marc Ranger wrote: > You're well-placed to know since you're the credited author :) So > agreed, my mistake. Well, I just made a couple of minimal patches, Matthew Palmer is the main author. > Other comments ? debian/changelog - add (Closes: #333237) - when someone sponsors the upload, make sure they build the package with the "-v 0.0.20050620-1" option to debuild/dpkg-buildpackage. That way all the changlog entries will be included in the upload and your ITP bug will be closed. In line with the developers reference, I recommend you change the last two lines of debian/control to this: Homepage: http://aluminum.sourmilk.net/adm8211/ Standards-Version is only 3 numbers - 1.2.3.X releases are all compatible - only minor changes like typos/etc. Depends: hotplug - hmm, this is tricky, since hotplug is being replaced by udev right now - check the debian-devel archives for more details/flamewars. debian/copyright: I would make some stylistic changes: ------------------------------------------------------------------------------ ... Copyright: Copyright 2003 Jouni Malinen <jkmaline@cc.hut.fi> Copyright 2004-2005 Michael Wu <flamingice@sourmilk.net> License: This package is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This package is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. On Debian systems, the complete text of the GNU General Public License can be found in `/usr/share/common-licenses/GPL'. ------------------------------------------------------------------------------ debian/docs: INSTALL and NOTES-FC2 probably aren't relevant. debian/README.Debian: I don't see any README file in the source package, is it generated at build time or something? "Please see ./README for a description of the adm8211 driver." debian/README.Debian: AFAIK, module assistant does all the unpacking, no need to put the cd/tar debian/rules: Lots of sponsors like it if you remove commedted out dh_* lines because it makes the rules file look cleaner and is more readable. Trying to build the modules failed for me, I think you have to get adm8211 registered in the module-assistant package: # m-a a-i adm8211 adm8211, what is adm8211? Personally, I think there needs to be /usr/share/modass/compliant.list.d - you may want to file a wishlist bug about this against m-a (in addition to one asking for adding adm8211-source to /usr/share/modass/compliant.list) Don't forget to check your package with lintian and linda: > Now running lintian... > W: adm8211-source: package-contains-upstream-install-documentation usr/share/doc/adm8211-source/INSTALL > N: > N: Binary packages do not need to contain the instructions for building > N: and installing the package as this info is not needed by package > N: users. If the info contained is important for configuration perhaps it > N: could be summarized in README.Debian, otherwise an override may be > N: added. > N: > N: Refer to Policy Manual, section 12.3 for details. > N: > E: adm8211-source: old-fsf-address-in-copyright-file > N: > N: The /usr/share/doc/<pkg>/copyright file refers to the old postal > N: address of the Free Software Foundation (FSF). The new address is: > N: > N: Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > N: MA 02110-1301, USA. > N: Here is a useful ~/.devscripts file: export DEBUILD_DPKG_BUILDPACKAGE_OPTS="-us -uc -i -ICVS -I.svn" export DEBUILD_LINDA=yes export DEBUILD_LINTIAN_OPTS=-i export DEBUILD_LINDA_OPTS=-i -- bye, pabs http://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part