[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sidplay-libs, sidplay



On Tue, Aug 24, 2004 at 01:25:36AM +0200, Laszlo 'GCS' Boszormenyi wrote:
>http://mentors.debian.net/debian/pool/main/s/sidplay-libs/

Builds fine with pbuilder. No lintian/linda messages.

debian/copyright is missing the following lines (maybe more) [6][7]:

Copyright (C) Michael Schwendt <mschwendt@yahoo.com>
copyright (C) 2000 by Simon White
copyright (C) 2000 by Dag Lem
copyright (C) 2000 by Simon White
Copyright (C) 2001 Simon White <sidplay2@email.com>
Copyright (C) Michael Schwendt <mschwendt@yahoo.com>
Copyright (C) 1999 Aladdin Enterprises.  All rights reserved.
Copyright (C) 1999  Dag Lem <resid@nimrod.no>
Copyright (C) 2002  Dag Lem <resid@nimrod.no>
Copyright (C) 1997 André Fachat (a.fachat@physik.tu-chemnitz.de)

It seems to me that there are many licenses involved in this package.
I didn't have time to check them. They must be mentioned in
debian/copyright [6][7].

Please include the upstream homepage in the description in
debian/control [8][9].

>http://mentors.debian.net/debian/pool/main/s/sidplay/

Builds fine with pbuilder as well.

Please fix the following lintian/linda problems:

lintian -i /home/pbuilder/result/sidplay/sidplay_2.0.8-1_i386.changes
W: sidplay: binary-or-shlib-defines-rpath ./usr/bin/sidplay2 /usr/lib/
N:
N:   The binary or shared library defines the `RPATH'. Usually this is a
N:   bad thing. Most likely you will find a Makefile with a line like:
N:       gcc test.o -o test -Wl,--rpath
N:   or
N:       gcc test.o -o test -R/usr/local/lib
N:   Please contact debian-devel@lists.debian.org if you have questions
N:   about this.
N:

linda -i /home/pbuilder/result/sidplay/sidplay_2.0.8-1_i386.changes
W: sidplay; Binary /usr/bin/sidplay2 compiled with an RPATH of /usr/lib/.
 This binary or shared library defines the `RPATH', which is usually a
 bad thing.  Most likely you will find a Makefile with a line like: gcc
 test.o -o test -Wl,--rpath

debian/copyright is missing the following lines [6][7]:

Copyright 2000 Simon White (s_a_white@email.com)
Copyright 2000 Mikko Kilponen (mikil@uni.kaapeli.net)
copyright (C) 2000 by Jarno Paananen

Please include the upstream homepage in the description in
debian/control [8][9].

[6] http://lists.debian.org/debian-devel-announce/2003/12/msg00007.html
[7] http://lists.debian.org/debian-legal/2003/12/msg00194.html
[8] http://people.debian.org/~walters/descriptions.html
[9] http://www.debian.org/doc/developers-reference/ch-best-pkging-practices.en.html#s-bpp-upstream-info

Anibal Monsalve Salazar
--
 .''`. Debian GNU/Linux      | Building 28C
: :' : Free Operating System | Monash University  VIC 3800  Australia
`. `'  http://debian.org/    | http://www-personal.monash.edu/~anibal
  `-

Attachment: signature.asc
Description: Digital signature


Reply to: