[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

q2-sample-classifier: Missing dependencies - upload?



Hi,

I was adding in autopkgtests for q2-sample-classifier and I noticed that this has a few
missing dependencies, which must be included for it to work properly.

$ grep -irn distutils

versioneer.py:1504:    from distutils.core import Command
versioneer.py:1546:        from distutils.command.build_py import build_py as _build_py
versioneer.py:1597:            from py2exe.distutils_buildexe import py2exe as _py2exe  # py3
versioneer.py:1627:        from distutils.command.sdist import sdist as _sdist

$ grep -irn q2_types 
q2_sample_classifier/tests/test_estimators.py:22:from q2_types.feature_table import (FeatureTable, PercentileNormalized)
q2_sample_classifier/tests/test_types_formats_transformers.py:21:from q2_types.feature_data import FeatureData
q2_sample_classifier/tests/test_types_formats_transformers.py:23:from q2_types.sample_data import SampleData


$ grep -irn q2_feature_table
q2_sample_classifier/plugin_setup.py:20:from q2_feature_table import heatmap_choices

All fixes in salsa

Do you think it is fine uploading this now and filing a unblock request?
Or should this be marked as due for a stable point release instead?

Nilesh

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: