Re: libbarclay-java needs update, libpicard-java runtime tests by pigx-scrnaseq
Wow! [email ends here since still speachless]
On 11.09.20 00:01, Pierre Gruet wrote:
> Hi,
>
> Le 10/09/2020 à 17:11, Andreas Tille a écrit :
>> Hi Steffen,
>>
>> On Thu, Sep 10, 2020 at 03:32:49PM +0200, Steffen Möller wrote:
>>> libpicard-java needs an argparse class from the barclay library. This
>>> was found by the intense build-time testing of the PIGx-scRNAseq.
>>> ...
>>> How shall I/we proceed? My immediate plan was to just update locally to
>>> vesion 4.0.0 (released a few days ago) and see if the two reverse
>>> dependencies still build.
>> From my naive point of view the migration to a recent libbarclay-java
>> should be easy given that only two packages in our hands are rdepends
>> of it. Thus I was running routine-update on barclay[1] but the build
>> is running into:
>>
>> ...
>> radle Test Executor 1 finished executing tests.
>> Results: FAILURE (346 tests, 344 successes, 2 failures, 0 skipped)
>>
>>
>> Pierre, can you help? ;-)
>>
> I have had a really hard time, but I finally found the issue (a
> LinkedHashMap was wrongly iterated over in a Freemarker template), now
> all build tests are passing and the .deb can be built :-)
> I have pushed my changes to Salsa.
>
> Could someone do some final checks (maybe forward the patch I have written)?
>
>>> If this update then then happens to also fix
>>> the failed test of PIGx-scRNAseq, then this shall be it. Alternatively,
>>> well, we would need versioned library packages, then, and I'll see how
>>> far version 3 carries me.
>> I do not think we should spent time on a version that just became
>> outdated so version 4 should most probably be our target.
>>
>>> Right? If there is anyone out there who is a
>>> bit closer to the barclay library, please direct me if there is any need
>>> to keep the older version 2 in the archive.
>> Libpicard-java needs an update as well - so I'd suggest to upgrade
>> libbarclay-java first and than see how to continue (may be together
>> with upstream).
>>
>> Disclaimer: All I said is probably absolutely naive and not based on
>> any deeper knowledge about the software involved simply guided by my gut
>> feeling about what usually was a sensible strategy.
>>
> I do not know barclay either but I would say the same.
>
>> Kind regards
>>
>> Andreas.
>>
>> [1] https://salsa.debian.org/java-team/barclay
>>
> Best regards,
> Pierre
>
Reply to: