Hello Andreas et. al., Just a quick update. I have fixed the python files to the extent that they now execute, but a few assertions arise. Maybe someone can glance over this at some point. Other than that, with bin/ removed, maybe an upload to accommodate as dependency for the marginphase package. A log if anyone is interested: https://paste.debian.net/1154009/ Kind regards, Shayan Doust On 25/06/2020 18:03, Shayan Doust wrote: > Hello Andreas, > >> Sounds good. I've opened an ITP for libsonlib. >> >> To finalise the package please remove the test suite binaries from >> /usr/bin. As extra bonus you could recreate those binaries in >> autopkgtest which is currently non-functional. If this turns out to >> much work please remove the non-functional test for the moment. > > Ah great. I will remove the test suite binaries from usr/bin/ later today. > > More of a general note: there seems to be quite a few things wrong with > the python files used to invoke the test binaries (2to3 seemingly loves > to change "import y" to "from x import y" or "from . import y") which > won't seem to work when the python files are ran in the same directory, > so maybe someone can look into fixing this (I cannot work at all when my > room is 30+*c like it is for the past couple of days so maybe someone > can do this quicker than I can). > > I will disable this allTests.py invoked in the Makefile, however I > believe there are one or two test binaries that can be invoked without > any input, and they pass, so at least this provides some coverage till > the python files are fixed (there are segmentation faults with the > others due to expecting certain files and arguments which is probably > what allTests.py does). > > Either way, I will build these binaries as is and simply move them to a > directory under debian/tests/, so that this can be prepared for autopkgtest. > > Kind regards, > Shayan Doust > > On 24/06/2020 10:23, Andreas Tille wrote: >> Hi Shayan, >> >> On Tue, Jun 23, 2020 at 06:03:41PM +0100, Shayan Doust wrote: >>> As for all of this, I am at a stage where libSon builds, and so does >>> marginPhase now :) >> >> Sounds good. I've opened an ITP for libsonlib. >> >> To finalise the package please remove the test suite binaries from >> /usr/bin. As extra bonus you could recreate those binaries in >> autopkgtest which is currently non-functional. If this turns out to >> much work please remove the non-functional test for the moment. >> >> I've also seen strange >> >> I: libsonlib-dev: unstripped-static-library usr/lib/x86_64-linux-gnu/sonLib.a(bioioC.o) >> I: libsonlib-dev: unstripped-static-library ... use --no-tag-display-limit to see all (or pipe to a file/program) >> >> issues - may be some override for dh_strip might help. No idea - >> I have never seen it before and would not spent to much time on it. >> >> Thanks for your work on this >> >> Andreas. >>
Attachment:
0x6D7D441919D02395.asc
Description: application/pgp-keys
Attachment:
signature.asc
Description: OpenPGP digital signature