Re: prinseq(-lite), a dependency of virus seeker
Hi Étienne,
thanks a lot for your work on this package.
On Sat, Apr 11, 2020 at 04:47:18PM +0200, Étienne Mollier wrote:
> Andreas Tille, on 2020-04-11 16:09:10 +0200:
> > BTW, when having .pl files a typical pitfall is if you have a manpage
> > named manpage.pl.1. This is considerd a manpage written in Polish
> > language. You can checkout this example
> >
> > https://salsa.debian.org/med-team/sprai/-/blob/master/debian/rules#37
> >
> > how to work around this.
>
> I had a look at the Antoni's implementation, and applied similar
> approach, to sort the "no extension" vs ".pl" issue. I pushed
> the change on Salsa. This settles the question apparently.
>
> The package is now in a shape I'm happy with. :)
Its nice to be happy with the own work. ;-)
I hope if I do not spoil your happiness if I'm a bit picky here.
The latest Standards-Version is 4.5.0. You can check this here:
https://tracker.debian.org/pkg/debian-policy
(only the first three digits are relevant thus we do not use 4.5.0.1)
The autopkgtest is failing:
cp: cannot stat '/usr/share/doc/prinseq-lite/examples/*': No such file or directory
autopkgtest [16:25:11]: test run-unit-test: -----------------------]
autopkgtest [16:25:11]: test run-unit-test: - - - - - - - - - - results - - - - - - - - - -
When following the Debian Med scheme to make the autopkgtest user
runnable you need to install the example data into the binary package
as example.
You specify
Architecture: any
but as far as I can see it should be
Architecture: all
since its just Perl
Finally d/copyright should be cleaned up. The Comment should be removed (if you
have done what it says ;-))
Moreover the typical snippet for GPL-3+ is missing. You need to provide an
extra "License: GPL-3+" paragraph - you'll find lots of examples on your
Debian system.
Feel free to ask if you have any questions to my remarks.
Thanks again
Andreas.
--
http://fam-tille.de
Reply to: