[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: figtree autopkgtest



Ho,

On 30.11.2017 10:07, Andreas Tille wrote:
> thanks for your comments.  I'd really love if more people become
> involved in autopkgtests and teaching newcomers!

I am also a newcomer with respect to autopackage tests.

> On Wed, Nov 29, 2017 at 10:30:14PM +0100, Fabian Klötzl wrote:
>> One issue I have with DEP-8 (autopackagetest) is that it is unspecified
>> *what* shall be tested. Eg. how do we verify that figtree does indeed
>> produce a correct phylogeny and not just an empty file?
> 
> I have seen *very* simple autopkgtests that are just running a
> 
>    program -h
> 
> successfully.  DEP-8 is not specifying this exactly but even very basic
> testing is better than no testing at all.  I admit we should rather gain
> for more detailed tests but for some GUI only programs this could be an
> option, thought.

I think it would be an OK compromise for Debian Med to just check if a
tool runs and leave the functionality testing to the upstream author,
where it belongs. Afterall, it is call auto*pkg*tests.

>>> I am attaching  the patch file - since it is my first try for writing a
>>> test and even using the 'git format-patch' command , any feedback will
>>> be much appreciated.
>>
>> I am kind of surprised to see that your third testcase actually works
>> (creating a gif). Because it doesn't work on my Arch Linux machine and I
>> even opened an issue upstream [1]. Looks like I have to do some
>> investigations.
> 
> GIF does not work for me as well and I do not think that this is a
> drawback since PNG is working instead.  May be that's a documentation
> issue.  Someone might like to check SVG.

GIF works just fine on my Ubuntu LTS‽

Fabian


Reply to: