Re: figtree autopkgtest
Hi Fabian,
thanks for your comments. I'd really love if more people become
involved in autopkgtests and teaching newcomers!
On Wed, Nov 29, 2017 at 10:30:14PM +0100, Fabian Klötzl wrote:
> One issue I have with DEP-8 (autopackagetest) is that it is unspecified
> *what* shall be tested. Eg. how do we verify that figtree does indeed
> produce a correct phylogeny and not just an empty file?
I have seen *very* simple autopkgtests that are just running a
program -h
successfully. DEP-8 is not specifying this exactly but even very basic
testing is better than no testing at all. I admit we should rather gain
for more detailed tests but for some GUI only programs this could be an
option, thought.
> Do we want to
> check whether it only runs, or can we test the full GUI?
That's definitely harder and I added xvfb as a very first step to the
suggested test ... even if I'm not convinced that this makes any real
sense I intended to bring in this idea into the discussion.
> The latter is
> harder, but should be our goal in an ideal world.
Please let me know if you found the path to that ideal world. :-P
> > I am attaching the patch file - since it is my first try for writing a
> > test and even using the 'git format-patch' command , any feedback will
> > be much appreciated.
>
> I am kind of surprised to see that your third testcase actually works
> (creating a gif). Because it doesn't work on my Arch Linux machine and I
> even opened an issue upstream [1]. Looks like I have to do some
> investigations.
GIF does not work for me as well and I do not think that this is a
drawback since PNG is working instead. May be that's a documentation
issue. Someone might like to check SVG.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: