Re: RFS: qtltools -- Tool set for molecular QTL discovery and analysis

[Dylan <bob.dybian@gmail.com>]

Hi Afif,


2016-12-02 10:33 GMT+01:00 Dylan <bob.dybian@gmail.com>:
> Hi Afif,
>
> Thanks for your review and your useful comments :-)
>
> 2016-12-02 10:11 GMT+01:00 Afif Elghraoui <afif@debian.org>:
>>
>> Many thanks for preparing this package. My comments:
>>
>> * Rather than patch the include statements for libeigen in the source,
>> it is more sustainable to append -I/usr/include/eigen3 to CPPFLAGS in
>> debian/rules (using DEB_CPPFLAGS_MAINT_APPEND). This will save you
>> maintenance of a patch and provide more flexibility.
>
>> * very minor: the folder debian/upstream.docs has data inside it rather
>> than documentation. Would you clarify this in README.source or use a
>> more intuitive name?
>>

I have updated the package according to your comments.

Thanks

Best regards,
Dylan