[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Request for sponsoring: dcmtk to experimental

On Mon, May 09, 2016 at 12:03:19PM +0200, Gert Wollny wrote:
> With the URL's I saw the lintian info, and thought, okay, next time.  

umh, not sure why you would defer such easy task.  but it's done now.

> As for the predantic lintian message, fine as well, I usually don't run
> these checks though.

I'm used to ask lintian for all the tags all levels down to pedantic and
experimental, as they usually make sense and makes sense to fix them.

> > For the next one, could you please have a look at enabling parallel
> > building it, and maybe enabling hardening?
> The parallel build are enabled, at least in the way I know (i.e. 
> d/rules contains : 
> %: 
> 	dh  $@ --parallel
> And when I run "gbp buildpackage -j7" it compiles in parallel. 

oh, sorry, indeed it does.  I must have overlooked this.
I indeed have a
    make -j3
in the build log.  I was probably off becuase the build looked slower
than I expected it.

> Hardening should also be enabled, at least I see the 
> -D_FORTIFY_SOURCE=2 compile flag when compiling.  I know that there are
> some lintian warnings that indicate otherwise, but in my experience the
> compiler sometimes just optimizee things away because it sees that the
> hardening code is not needed, and then lintian warns about it. 

That's not the (only) hardening I'm talking about, but about PIE and
bindnow, and that has nothing to do with optimazation (?).

> Best, 
> Gert 

                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature

Reply to: