[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: kmer-tools



Hi, Andreas,

On السبت  2 أيار 2015 22:25, Andreas Tille wrote:
Hi Afif,

I have checked your last commits and would like to comment on it.  You
have created several binary packages - withpout checking I'm guessing
one per binary in /usr/bin.  While this is a possible thing to do I
think this is over-engineering and creates a lot of work for you with
no practical use.

I was starting to think the same thing as I saw that I would have to manage the interdependencies if I kept along this route. My only concern was that some of these packages have quite different functions. I suspect they are only distributed together because they share some dependencies and are written by the same developer. But you're right, I think it's not worth all the extra bugs that will undoubtedly come out of it.


I think we could go with maximum four packages:

    libkmer<soversion>
    libkmer-dev
    kmer-tools (or some similar name)
    libkmer-doc

The text you added as descriptions in debian/control might be useful for
some manpages for the tools.


Sounds good. What could the <soversion> be? I have a svn snapshot-- can I use what I have for the package version?


Other hints for the packaging:  You need to add your ID (the same string
as in debian/changelog) as Uploaders in debian/control.


Will do

Please also use UNRELEASED as target distribution in debian/changelog
(instead of "unstable").


Also will do. I haven't made my way over to edit that file yet.

Finally in the Git repository the pristine-tar branch is missing.  Did
you imported the upstream tarball using

     git import-orig --pristine-tar       ?


No, I was actually going to ask about this-- there are no official upstream releases, so there's no original tarball. I took the snapshot of the svn repository from sourceforge, which came to me as a zip-file. I unzipped it and then made it a tar.xz archive.

But this is a mistake I made with the wgs-assembler git conversion that I will take care.

If yes, please push all branches.  If no, please do the latter as
described in Debian Med policy.


I will try to do better about following the policy. I have 4-5 sets of documentation that I keep flipping back and forth between and I sometimes forget to make sure my final work is policy-compliant.

Kind regards and thanks for your work on this


Thanks for checking my commits :)

Regards
Afif

--
Afif Elghraoui | عفيف الغراوي
http://afif.ghraoui.name


Reply to: