[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [med-svn] r1219 - in trunk/packages/axparafit/trunk: . debian debian/patches



Am Mittwoch, den 30.01.2008, 20:37 +0900 schrieb Charles Plessy:

> just a few comments:

I would like to add some more.

> Le Wed, Jan 30, 2008 at 10:54:18AM +0000, hanska-guest@alioth.debian.org a écrit :
> > 
> > Added: trunk/packages/axparafit/trunk/debian/axparafit.1.xml
> > ===================================================================
> > --- trunk/packages/axparafit/trunk/debian/axparafit.1.xml	                        (rev 0)
> > +++ trunk/packages/axparafit/trunk/debian/axparafit.1.xml	2008-01-30 10:54:18 UTC (rev 1219)
> > @@ -0,0 +1,228 @@
> > +<?xml version='1.0' encoding='UTF-8'?>
> > +<?xml-stylesheet type="text/xsl"
> > +        href="http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl";?>
> > +<!DOCTYPE refentry PUBLIC "-//OASIS//DTD DocBook XML V4.5//EN"
> > +"http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"; [

Lokking into the XML source I see, there is a separate AUTHORS section.
Please remove this and instead use <author> or <authorgroup> and related
tags in <refentryinfo>. The styleshgeets automatically care about
creating an authors section. The legal notice also should be put into
<legalnotice>. Here also the stylesheets create the necessary section.
The template you used is pretty old and outdated. dh-make already ships
a newer one in SVN (but seems to not have released it yet - there are
open bug reports about it).

To see a recent example,
check /usr/share/doc/docbook-xsl/examples/foo.1.example_manpage.xml.gz.


> > +DB2MAN=/usr/share/sgml/docbook/stylesheet/xsl/nwalsh/\
> > +manpages/docbook.xsl
> > +XP=xsltproc -''-nonet
                  ^^

This is just a workaround for the XML source: "--" is not allowed in XML
comments, so we use "-''-" as a workaround. But you can saefely remove
the single quotation marks.

Further please add 

--param man.charmap.use.subset "0"

to replace *all* special characters. Otherwise only a subset of the
groff charmap is used and mandb might throw errors because of unknown
characters.

[snip]
> > Added: trunk/packages/axparafit/trunk/debian/axparafitblas.1
> > ===================================================================
> > --- trunk/packages/axparafit/trunk/debian/axparafitblas.1	                        (rev 0)
> > +++ trunk/packages/axparafit/trunk/debian/axparafitblas.1	2008-01-30 10:54:18 UTC (rev 1219)
> > @@ -0,0 +1 @@
> > +.so man1/axparafit.1
> 
> The Debian Policy §12.1 recommends to use symlinks anyway (but
> dh_installman takes care of doing this).

Yes. No need to change anything.

[..]
> > Added: trunk/packages/axparafit/trunk/debian/dirs
> > ===================================================================
> > --- trunk/packages/axparafit/trunk/debian/dirs	                        (rev 0)
> > +++ trunk/packages/axparafit/trunk/debian/dirs	2008-01-30 10:54:18 UTC (rev 1219)
> > @@ -0,0 +1,2 @@
> > +usr/bin
> > +usr/share/man/man1
> 
> debian/dirs does not seem to be required.

It's just required if you manually copy or install something. dh_install
and Co. normally automatically take care of creating directories.

> > +XP=xsltproc -o debian/ -''-nonet
> 
> The two apostrophes are not necessary in debian/rules (only in the XML
> source)

See above for the explanation.

Regards, Daniel


Reply to: