[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [med-svn] r1219 - in trunk/packages/axparafit/trunk: . debian debian/patches



Hi David,

just a few comments:

Le Wed, Jan 30, 2008 at 10:54:18AM +0000, hanska-guest@alioth.debian.org a écrit :
> 
> Added: trunk/packages/axparafit/trunk/debian/axparafit.1.xml
> ===================================================================
> --- trunk/packages/axparafit/trunk/debian/axparafit.1.xml	                        (rev 0)
> +++ trunk/packages/axparafit/trunk/debian/axparafit.1.xml	2008-01-30 10:54:18 UTC (rev 1219)
> @@ -0,0 +1,228 @@
> +<?xml version='1.0' encoding='UTF-8'?>
> +<?xml-stylesheet type="text/xsl"
> +        href="http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl";?>
> +<!DOCTYPE refentry PUBLIC "-//OASIS//DTD DocBook XML V4.5//EN"
> +"http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"; [

> +DB2MAN=/usr/share/sgml/docbook/stylesheet/xsl/nwalsh/\
> +manpages/docbook.xsl
> +XP=xsltproc -''-nonet
> +
> +manpage.1: manpage.dbk
> +        $(XP) $(DB2MAN) $<

You do not need $(DB2MAN) anymore since the xsl stylesheet is declared
at lines 2 & 3.


> Added: trunk/packages/axparafit/trunk/debian/axparafitblas.1
> ===================================================================
> --- trunk/packages/axparafit/trunk/debian/axparafitblas.1	                        (rev 0)
> +++ trunk/packages/axparafit/trunk/debian/axparafitblas.1	2008-01-30 10:54:18 UTC (rev 1219)
> @@ -0,0 +1 @@
> +.so man1/axparafit.1

The Debian Policy §12.1 recommends to use symlinks anyway (but
dh_installman takes care of doing this).

> Added: trunk/packages/axparafit/trunk/debian/compat
> ===================================================================
> --- trunk/packages/axparafit/trunk/debian/compat	                        (rev 0)
> +++ trunk/packages/axparafit/trunk/debian/compat	2008-01-30 10:54:18 UTC (rev 1219)
> @@ -0,0 +1 @@
> +6

Unless you need a feature of Debhelper 6, I recommend to keep 5 until
Etch support is dropped: this facilitates home-made backports (I think
that backports.org provides an up-to-date debhelper environment).

> --- trunk/packages/axparafit/trunk/debian/control	                        (rev 0)
> +++ trunk/packages/axparafit/trunk/debian/control	2008-01-30 10:54:18 UTC (rev 1219)
> +Build-Depends: debhelper (>= 6), quilt,
> + refblas3-dev, atlas3-base-dev, libmpich1.0-dev
 
> Added: trunk/packages/axparafit/trunk/debian/copyright
> ===================================================================
> --- trunk/packages/axparafit/trunk/debian/copyright	                        (rev 0)
> +++ trunk/packages/axparafit/trunk/debian/copyright	2008-01-30 10:54:18 UTC (rev 1219)
> @@ -0,0 +1,24 @@
> +Source: http://icwww.epfl.ch/~stamatak/AxParafit.html
> +
> +Files: debian/*
> +Copyright: © 2008, David Paleino <d.paleino@gmail.com>
> +License: GPL-3+

I am not completely sure, but maybe it is required that the libraries
axparafit is built upon are compatible with GPLv3 if you use this for
the packaging scripts. I would recommend checking or downgrading.
(Usually, I like to use a "same as $(packaged program) license").

> Added: trunk/packages/axparafit/trunk/debian/dirs
> ===================================================================
> --- trunk/packages/axparafit/trunk/debian/dirs	                        (rev 0)
> +++ trunk/packages/axparafit/trunk/debian/dirs	2008-01-30 10:54:18 UTC (rev 1219)
> @@ -0,0 +1,2 @@
> +usr/bin
> +usr/share/man/man1

debian/dirs does not seem to be required.


> +XP=xsltproc -o debian/ -''-nonet

The two apostrophes are not necessary in debian/rules (only in the XML
source)




Have a nice day,

-- 
Charles Plessy
http://charles.plessy.org
Wakō, Saitama, Japan


Reply to: