[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New upload for proda



Il giorno Sat, 29 Sep 2007 16:21:13 -0300
"Nelson A. de Oliveira" <naoliv@gmail.com> ha scritto:

> Hi!

Hi,

> On 9/29/07, David Paleino <d.paleino@gmail.com> wrote:
> > Secondly, I've just noticed that proda compiled with debug flags. This made
> > proda a ~600K application, while with debug flags turned off, it is around
> > 180K. I believe it's a good improvement ;)
> 
> Actually you need to build with debug symbols enabled (-g with gcc and g++).

I didn't know this -- maybe I should read Policy better.

> There won't be any difference on the final binary package if you use
> -g, since dh_strip will remove the debug symbols.

Aw, right, didn't think that.

> Compiling with debug symbols is good, since we can use
> DEB_BUILD_OPTIONS=nostrip and create a package for debug purposes
> (when dh_strip finds "nostrip", it won't remove the debug symbols).
> 
> So it's unnecessary to remove the -g flag from the Makefile.

Fixed.

> Also, you are hardcoding the CXXFLAGS in your patch, that is also not
> good (for example, the noopt option won't work; your package will
> always be compiled with -O2, instead -O0).
> 
> The best thing to do is to use
> $(MAKE) CXXFLAGS="$(CXXFLAGS)"
> on line 26 of your debian/rules, and include all the needed flags on
> the beginning, where you define CFLAGS (it should be CXXFLAGS).

Done :)

> And "dch -r" is your friend and it will updated the UNRELEASED entry
> in changelog to unstable ;-)

Done as well.

I think it's ready for an upload. ;)

> Best regards,
> Nelson

Have a nice day,
David

-- 
 . ''`.  Debian maintainer | http://snipurl.com/qa_page/
 : :'  :  Linuxer #334216  |  http://www.hanskalabs.net/
 `. `'`    GPG: 1392B174   | http://www.debianizzati.org/
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Attachment: signature.asc
Description: PGP signature


Reply to: