Re: RFC: getting rid of unpack-level
Raphael Geissert <geissert@debian.org> writes:
> Russ Allbery wrote:
>> Raphael Geissert writes:
>>> Some of my concerns are:
>>> * By moving the level 2 code to the "unpacked" collection script I had to
>>> add a flag so that it can be automatically removed whenever --keep-lab is
>>> not requested; but this doesn't allow for the old behaviour of specifying
>>> an unpack level for the whole lab.
>> Via the configuration file, you mean? This can be addressed by fixing
>> the open wishlist bug for providing a way to set Lintian options in its
>> configuration file.
> No, via --unpack-level.
Oh, I see. I think we should have some sort of --keep-lab equivalent for
static labs that keeps the auto-remove collection results. Maybe just
reusing --keep-lab for that purpose makes sense.
>> I think the right direction to go here is to replace the --unpack flag
>> with a flag that says to only run the collect scripts (but run all of
>> them).
> Right. This replacement combined with the to-be-added ability to exclude
> certain collection scripts should completely replace --unpack without
> any feature loss.
Yup.
> Summarising:
> * First two commits are OK
> * Third commit is fine too, except for the commit message
> * --unpack needs to be adapted to make it run all the collection scripts
> * an option to exclude certain collection scripts should be added once we
> switch to a dep-based process.
> Did I miss something?
Not that I can think of. Sounds right to me.
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to: