On 05/05/2011 06:39 AM, Christian PERRIER wrote:
> Please find, for review, the debconf templates and packages descriptions for the cardstories source package.
>
> This review will last from Thursday, May 05, 2011 to Sunday, May 15, 2011.
>
> Please send reviews as unified diffs (diff -u) against the original
> files. Comments about your proposed changes will be appreciated.
>
> Your review should be sent as an answer to this mail.
>
> When appropriate, I will send intermediate requests for review, with
> "[RFRn]" (n>=2) as a subject tag.
>
> When we will reach a consensus, I send a "Last Chance For
> Comments" mail with "[LCFC]" as a subject tag.
>
> Finally, the reviewed templates will be sent to the package maintainer
> as a bug report, and a mail will be sent to this list with "[BTS]" as
> a subject tag.
>
> Rationale:
> --- cardstories.old/debian/python-cardstories.templates 2011-04-27 19:43:05.610457093 +0200
> +++ cardstories/debian/python-cardstories.templates 2011-05-01 12:50:17.215424103 +0200
> @@ -20,6 +20,6 @@
> Choices: nginx
> _Description: Web server to reconfigure automatically:
> Please choose the web server that should be automatically configured
> - to run cardstories. If the web server provides http://localhost/,
> - cardstories can then be played at http://localhost/cardstories/
> + to run cardstories. If the web server provides http://<host_name>/,
> + cardstories can then be played at http://<host_name>/cardstories/.
>
> I find it confusing to give "localhost" as example, probably best to
> be more generic.
>
> --- cardstories.old/debian/control 2011-04-27 19:43:05.610457093 +0200
> +++ cardstories/debian/control 2011-05-01 12:53:20.611982573 +0200
> @@ -25,14 +25,17 @@
> python-openssl,
> ${python:Depends}
> Provides: ${python:Provides}
> -Description: Find out a card using a sentence made up by another player
> - A player (who we will call the author) creates a new game.
> - He chooses a card, picks a word or a sentence to describe it
> - and invites players to participate.
> - Each players is given seven cards and are required to pick
> - one that best matches the author's sentence.
> +Description: card guessing game
> + This package provides a game where a player (the "author") chooses
> + a card, picks a word or a sentence to describe it
> + and invites other players to guess it.
> + .
> + Each player receives seven cards and has to pick
> + one that best matches the author's description.
> + .
> Once enough players have chosen a card, the author displays all chosen
> cards and the players try to figure out which one is the author's.
> + .
> The author wins if at least one of the players guesses right, but not all
> of them do. The winners are the author and the players who guessed right.
> If the author loses, all the other players win.
>
> Description synopsis should be noun phrase, not a full
> sentence. Moreover, it seems sensible to mention this is a game..:-)
>
> The full description was generally rewritten in a more descriptive
> style rather than a copy/paste from the game's rules. I still left the
> details. After all, they don't hurt...:-)
>
>
Hi,
The only modification I would suggest is:
=> "and invites other players to guess his card"
instead of the proposed:
+ and invites other players to guess it.
Unless you advise otherwise, I will wait for your final comments and the corresponding bug report
before applying the changes.
Thanks for your help
begin:vcard fn:Loic Dachary n:Dachary;Loic org:Artisan Logiciel Libre adr:;;12 bd Magenta;Paris;;75010;France email;internet:loic@dachary.org title:Senior Developer tel;work:+33 4 84 25 08 05 tel;home:+33 9 51 18 43 38 tel;cell:+33 6 64 03 29 07 note:Born 131414404 before EPOCH. url:http://dachary.org/ version:2.1 end:vcard
Attachment:
signature.asc
Description: OpenPGP digital signature