Please find, for review, the debconf templates and packages descriptions for the cardstories source package.
This review will last from Thursday, May 05, 2011 to Sunday, May 15, 2011.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- cardstories.old/debian/python-cardstories.templates 2011-04-27 19:43:05.610457093 +0200
+++ cardstories/debian/python-cardstories.templates 2011-05-01 12:50:17.215424103 +0200
@@ -20,6 +20,6 @@
Choices: nginx
_Description: Web server to reconfigure automatically:
Please choose the web server that should be automatically configured
- to run cardstories. If the web server provides http://localhost/,
- cardstories can then be played at http://localhost/cardstories/
+ to run cardstories. If the web server provides http://<host_name>/,
+ cardstories can then be played at http://<host_name>/cardstories/.
I find it confusing to give "localhost" as example, probably best to
be more generic.
--- cardstories.old/debian/control 2011-04-27 19:43:05.610457093 +0200
+++ cardstories/debian/control 2011-05-01 12:53:20.611982573 +0200
@@ -25,14 +25,17 @@
python-openssl,
${python:Depends}
Provides: ${python:Provides}
-Description: Find out a card using a sentence made up by another player
- A player (who we will call the author) creates a new game.
- He chooses a card, picks a word or a sentence to describe it
- and invites players to participate.
- Each players is given seven cards and are required to pick
- one that best matches the author's sentence.
+Description: card guessing game
+ This package provides a game where a player (the "author") chooses
+ a card, picks a word or a sentence to describe it
+ and invites other players to guess it.
+ .
+ Each player receives seven cards and has to pick
+ one that best matches the author's description.
+ .
Once enough players have chosen a card, the author displays all chosen
cards and the players try to figure out which one is the author's.
+ .
The author wins if at least one of the players guesses right, but not all
of them do. The winners are the author and the players who guessed right.
If the author loses, all the other players win.
Description synopsis should be noun phrase, not a full
sentence. Moreover, it seems sensible to mention this is a game..:-)
The full description was generally rewritten in a more descriptive
style rather than a copy/paste from the game's rules. I still left the
details. After all, they don't hurt...:-)
--
# Copyright (C) 2011 Dachary <loic@dachary.org> # # This software's license gives you freedom; you can copy, convey, # propagate, redistribute and/or modify this program under the terms of # the GNU Affero General Public License (AGPL) as published by the Free # Software Foundation (FSF), either version 3 of the License, or (at your # option) any later version of the AGPL published by the FSF. # # This program is distributed in the hope that it will be useful, but # WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero # General Public License for more details. # # You should have received a copy of the GNU Affero General Public License # along with this program in a file in the toplevel directory called # "AGPLv3". If not, see <http://www.gnu.org/licenses/>. # Template: python-cardstories/reconfigure-webserver Type: multiselect Choices: nginx _Description: Web server to reconfigure automatically: Please choose the web server that should be automatically configured to run cardstories. If the web server provides http://<host_name>/, cardstories can then be played at http://<host_name>/cardstories/.
--- cardstories.old/debian/python-cardstories.templates 2011-04-27 19:43:05.610457093 +0200
+++ cardstories/debian/python-cardstories.templates 2011-05-01 12:50:17.215424103 +0200
@@ -20,6 +20,6 @@
Choices: nginx
_Description: Web server to reconfigure automatically:
Please choose the web server that should be automatically configured
- to run cardstories. If the web server provides http://localhost/,
- cardstories can then be played at http://localhost/cardstories/
+ to run cardstories. If the web server provides http://<host_name>/,
+ cardstories can then be played at http://<host_name>/cardstories/.
--- cardstories.old/debian/control 2011-04-27 19:43:05.610457093 +0200
+++ cardstories/debian/control 2011-05-01 12:53:20.611982573 +0200
@@ -25,14 +25,17 @@
python-openssl,
${python:Depends}
Provides: ${python:Provides}
-Description: Find out a card using a sentence made up by another player
- A player (who we will call the author) creates a new game.
- He chooses a card, picks a word or a sentence to describe it
- and invites players to participate.
- Each players is given seven cards and are required to pick
- one that best matches the author's sentence.
+Description: card guessing game
+ This package provides a game where a player (the "author") chooses
+ a card, picks a word or a sentence to describe it
+ and invites other players to guess it.
+ .
+ Each player receives seven cards and has to pick
+ one that best matches the author's description.
+ .
Once enough players have chosen a card, the author displays all chosen
cards and the players try to figure out which one is the author's.
+ .
The author wins if at least one of the players guesses right, but not all
of them do. The winners are the author and the players who guessed right.
If the author loses, all the other players win.
Source: cardstories
Section: python
Priority: optional
Maintainer: Loic Dachary (OuoU) <loic@debian.org>
Build-Depends: debhelper (>= 7.0.50~),
po-debconf,
python-all (>= 2.6.6-2~),
python-coverage,
python-twisted-web (>= 10.1),
python-twisted-mail,
jscoverage
Standards-Version: 3.9.2
Vcs-Git: http://cardstori.es/cardstories.git
Vcs-Browser: http://cardstori.es/trac/browser
Homepage: http://cardstori.es/
X-Python-Version: all
Package: python-cardstories
Section: python
Architecture: all
Depends: ${misc:Depends},
adduser,
python-twisted-web (>= 10.1),
python-twisted-mail,
python-openssl,
${python:Depends}
Provides: ${python:Provides}
Description: card guessing game
This package provides a game where a player (the "author") chooses
a card, picks a word or a sentence to describe it
and invites other players to guess it.
.
Each player receives seven cards and has to pick
one that best matches the author's description.
.
Once enough players have chosen a card, the author displays all chosen
cards and the players try to figure out which one is the author's.
.
The author wins if at least one of the players guesses right, but not all
of them do. The winners are the author and the players who guessed right.
If the author loses, all the other players win.
Attachment:
signature.asc
Description: Digital signature