[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://rinputd/{templates}



Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.
[...] 
> -Template: rinputd/about
[...]
>  Template: rinputd/username
>  Type: string
>  Default: rinput
> -_Description: Username:
> - This is the user account name for the SASL rinputd login. This has no bearing
> +_Description: SASL rinputd user name:
                                  ^
s/user name/username/ - this and userspace are the exceptions to the
usual rule, since the one-word technical term has a specialised
meaning.

> + Please enter the user name for the SASL rinputd login. This has no bearing

Make it "a" username (they're choosing one now, not trying to
remember what it was).

>   on the local login, and will not create a local user account, nor conflict
>   with the local user namespace.
> 
> Synopsis may appear isolated (without the long description). So
> "Username:" is too scarce.

In fact without the rinputd/about as introduction this could
probably do with a couple more words of explanation (it's a bit late
putting them in rinputd/passwd).

    Please enter a username for the SASL rinputd login.
    .
    This account will not be created as a local user with shell access.
    Instead it will allow control of the keyboard and mouse through the
    remote input daemon.

>  Template: rinputd/passwd
>  Type: password
> +_Description: SASL rinputd password:
> + Pleas enter the password for the rinputd sasl user account. This password is not related to
>   shell level login, but will allow control of the keyboard and mouse through
>   the rinputd daemon.

I've moved that explanation to the username step, so that leaves
just:

   _Description: SASL rinputd password:
    Please enter a password for the SASL rinputd login.

in debian/control:
> +Description: server daemon for receiving user input events
> + This package provides a server daemon which listens for remote input clients. Clients
>   connect over a secure SSL socket and authenticate with the server through the
>   Cyrus SASL password database /etc/sasldb2. The client may then initialize an
>   input device through the uinput user input event interface. After
>   initialization, the client may send input events such as key presses or mouse
>   movements.

The English here is fine, but, well, I have to say that all these
dry implementation details don't really convey quite what the point
of the exercise is.  When it talks about initialising a device, does
that mean creating a virtual device?   Does rinputd mean that I can
use an iphone app as a remote control for my GNOME session?  If so
it would really help if it said so. 

I won't actually include this in my patch, but here's an attempt:

 This package provides a remote input server daemon which listens for
 connections from rinput clients (such as mobile phone apps). These
 authenticate via a secure SSL socket through the Cyrus SASL password
 database, /etc/sasldb2. The uinput user input event interface can
 then create virtual devices such as a keyboard and mouse under the
 remote control of the client.

-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- rinputd-1.0.3.pristine/debian/templates	2010-03-30 00:29:20.000000000 +0100
+++ rinputd-1.0.3/debian/templates	2010-05-06 10:51:07.000000000 +0100
@@ -1,24 +1,20 @@
-Template: rinputd/about
-Type: text
-_Description: Configure the rinputd sasl username and password
- The following two prompts will help you set up a new sasl user account and
- password. This allows for remote access to this computer.
-
 Template: rinputd/username
 Type: string
 Default: rinput
-_Description: Username:
- This is the user account name for the SASL rinputd login. This has no bearing
- on the local login, and will not create a local user account, nor conflict
- with the local user namespace.
+_Description: SASL rinputd username:
+ Please enter a username for the SASL rinputd login.
+ .
+ This account will not be created as a local user with shell access.
+ Instead it will allow control of the keyboard and mouse through the
+ remote input daemon.
 
 Template: rinputd/passwd
 Type: password
-_Description: Password:
- Password for the rinputd sasl user account. This password is not related to
- shell level login, but will allow control of the keyboard and mouse through
- the rinputd daemon.
+_Description: SASL rinputd password:
+ Please enter a password for the SASL rinputd login.
 
 Template: rinputd/invalid
-Type: text
-_Description: Error: Invalid username or password
+Type: error
+_Description: Invalid username or password
+ Neither the SASL rinputd username nor the password can be empty.
+ Please correct them.
--- rinputd-1.0.3.pristine/debian/control	2010-04-25 17:12:24.000000000 +0100
+++ rinputd-1.0.3/debian/control	2010-05-06 10:48:59.000000000 +0100
@@ -12,8 +12,8 @@
 Architecture: i386 ia64 alpha amd64 armel hppa mips mipsel powerpc s390 sparc
 Depends: sasl2-bin, ${shlibs:Depends}, ${misc:Depends}
 Conflicts: rinputd
-Description: A server daemon for receiving user input events
- rinputd is a server daemon which listens for remote input clients. Clients
+Description: server daemon for receiving user input events
+ This package provides a server daemon which listens for remote input clients. Clients
  connect over a secure SSL socket and authenticate with the server through the
  Cyrus SASL password database /etc/sasldb2. The client may then initialize an
  input device through the uinput user input event interface. After
@@ -26,8 +26,8 @@
 Priority: extra
 Depends: rinputd (= ${binary:Version}), ${misc:Depends}
 Conflicts: rinputd-dbg
-Description: A server daemon for receiving user input events
- rinputd is a server daemon which listens for remote input clients. Clients
+Description: server daemon for receiving user input events - debug symbols
+ This package provides a server daemon which listens for remote input clients. Clients
  connect over a secure SSL socket and authenticate with the server through the
  Cyrus SASL password database /etc/sasldb2. The client may then initialize an
  input device through the uinput user input event interface. After
@@ -41,8 +41,8 @@
 Architecture: all
 Depends: ${misc:Depends}
 Conflicts: rinput-dev
-Description: A server daemon for receiving user input events
- rinputd is a server daemon which listens for remote input clients. Clients
+Description: server daemon for receiving user input events - development files
+ This package provides a server daemon which listens for remote input clients. Clients
  connect over a secure SSL socket and authenticate with the server through the
  Cyrus SASL password database /etc/sasldb2. The client may then initialize an
  input device through the uinput user input event interface. After
Template: rinputd/username
Type: string
Default: rinput
_Description: SASL rinputd username:
 Please enter a username for the SASL rinputd login.
 .
 This account will not be created as a local user with shell access.
 Instead it will allow control of the keyboard and mouse through the
 remote input daemon.

Template: rinputd/passwd
Type: password
_Description: SASL rinputd password:
 Please enter a password for the SASL rinputd login.

Template: rinputd/invalid
Type: error
_Description: Invalid username or password
 Neither the SASL rinputd username nor the password can be empty.
 Please correct them.
Source: rinputd
Section: net
Priority: optional
Maintainer: Chase Douglas <chase.douglas@ubuntu.com>
Standards-Version: 3.8.4
Build-Depends: cdbs, cmake, debhelper (>= 7), libavahi-client-dev, libavahi-qt4-dev, libqt4-dev, libsasl2-dev, po-debconf
Homepage: https://launchpad.net/rinput
VCS-bzr: http://bazaar.launchpad.net/~chasedouglas/rinput/debian/
VCS-browser: http://bazaar.launchpad.net/~chasedouglas/rinput/debian/files

Package: rinputd
Architecture: i386 ia64 alpha amd64 armel hppa mips mipsel powerpc s390 sparc
Depends: sasl2-bin, ${shlibs:Depends}, ${misc:Depends}
Conflicts: rinputd
Description: server daemon for receiving user input events
 This package provides a server daemon which listens for remote input clients. Clients
 connect over a secure SSL socket and authenticate with the server through the
 Cyrus SASL password database /etc/sasldb2. The client may then initialize an
 input device through the uinput user input event interface. After
 initialization, the client may send input events such as key presses or mouse
 movements.

Package: rinputd-dbg
Section: debug
Architecture: i386 ia64 alpha amd64 armel hppa mips mipsel powerpc s390 sparc
Priority: extra
Depends: rinputd (= ${binary:Version}), ${misc:Depends}
Conflicts: rinputd-dbg
Description: server daemon for receiving user input events - debug symbols
 This package provides a server daemon which listens for remote input clients. Clients
 connect over a secure SSL socket and authenticate with the server through the
 Cyrus SASL password database /etc/sasldb2. The client may then initialize an
 input device through the uinput user input event interface. After
 initialization, the client may send input events such as key presses or mouse
 movements.
 .
 This package contains debug symbols.

Package: rinput-dev
Section: devel
Architecture: all
Depends: ${misc:Depends}
Conflicts: rinput-dev
Description: server daemon for receiving user input events - development files
 This package provides a server daemon which listens for remote input clients. Clients
 connect over a secure SSL socket and authenticate with the server through the
 Cyrus SASL password database /etc/sasldb2. The client may then initialize an
 input device through the uinput user input event interface. After
 initialization, the client may send input events such as key presses or mouse
 movements.
 .
 This package contains a header defining rinput protocol values

Reply to: