[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://rinputd/{templates}



Please find, for review, the debconf templates and packages descriptions for the rinputd source package.

This review will last from Thursday, May 06, 2010 to Sunday, May 16, 2010.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- rinputd.old/debian/templates	2010-04-28 22:27:59.571513752 +0200
+++ rinputd/debian/templates	2010-05-02 14:22:55.463283235 +0200
@@ -1,24 +1,21 @@
-Template: rinputd/about
-Type: text
-_Description: Configure the rinputd sasl username and password
- The following two prompts will help you set up a new sasl user account and
- password. This allows for remote access to this computer.
-

This template is debconf abuse. It should be dropped entirely. There's
no point in warning users that they'll be prompted.

 Template: rinputd/username
 Type: string
 Default: rinput
-_Description: Username:
- This is the user account name for the SASL rinputd login. This has no bearing
+_Description: SASL rinputd user name:
+ Please enter the user name for the SASL rinputd login. This has no bearing
  on the local login, and will not create a local user account, nor conflict
  with the local user namespace.

Synopsis may appear isolated (without the long description). So
"Username:" is too scarce.

 
 Template: rinputd/passwd
 Type: password
-_Description: Password:
- Password for the rinputd sasl user account. This password is not related to
+_Description: SASL rinputd password:
+ Pleas enter the password for the rinputd sasl user account. This password is not related to
  shell level login, but will allow control of the keyboard and mouse through
  the rinputd daemon.

Same rationale.

 
 Template: rinputd/invalid
-Type: text
-_Description: Error: Invalid username or password
+Type: error
+_Description: Invalid username or password
+ Neither the SASL rinputd user name nor the password can be empty.
+ Please correct them.
+ 

Turn the template into "error" type, which most interfaces render in a
different way. It does make the "error" mention pointless.

Also add explanations about why things are invalid..:)

--- rinputd.old/debian/control	2010-04-28 22:27:59.571513752 +0200
+++ rinputd/debian/control	2010-05-02 14:24:20.283271755 +0200
@@ -12,8 +12,8 @@
 Architecture: i386 ia64 alpha amd64 armel hppa mips mipsel powerpc s390 sparc
 Depends: sasl2-bin, ${shlibs:Depends}, ${misc:Depends}
 Conflicts: rinputd
-Description: A server daemon for receiving user input events
- rinputd is a server daemon which listens for remote input clients. Clients
+Description: server daemon for receiving user input events
+ This package provides a server daemon which listens for remote input clients. Clients
  connect over a secure SSL socket and authenticate with the server through the
  Cyrus SASL password database /etc/sasldb2. The client may then initialize an
  input device through the uinput user input event interface. After

"A <foo>" is discouraged as synopsis (cf developer's reference)

Avoid leading lowercase by using our usual trick: "This package
provides blahblah"

@@ -26,8 +26,8 @@
 Priority: extra
 Depends: rinputd (= ${binary:Version}), ${misc:Depends}
 Conflicts: rinputd-dbg
-Description: A server daemon for receiving user input events
- rinputd is a server daemon which listens for remote input clients. Clients
+Description: server daemon for receiving user input events - debug symbols
+ This package provides a server daemon which listens for remote input clients. Clients
  connect over a secure SSL socket and authenticate with the server through the
  Cyrus SASL password database /etc/sasldb2. The client may then initialize an
  input device through the uinput user input event interface. After

Standard "general description - specific description" for synopsis

@@ -41,8 +41,8 @@
 Architecture: all
 Depends: ${misc:Depends}
 Conflicts: rinput-dev
-Description: A server daemon for receiving user input events
- rinputd is a server daemon which listens for remote input clients. Clients
+Description: server daemon for receiving user input events - development files
+ This package provides a server daemon which listens for remote input clients. Clients
  connect over a secure SSL socket and authenticate with the server through the
  Cyrus SASL password database /etc/sasldb2. The client may then initialize an
  input device through the uinput user input event interface. After

Ditto.

-- 


Template: rinputd/username
Type: string
Default: rinput
_Description: SASL rinputd user name:
 Please enter the user name for the SASL rinputd login. This has no bearing
 on the local login, and will not create a local user account, nor conflict
 with the local user namespace.

Template: rinputd/passwd
Type: password
_Description: SASL rinputd password:
 Pleas enter the password for the rinputd sasl user account. This password is not related to
 shell level login, but will allow control of the keyboard and mouse through
 the rinputd daemon.

Template: rinputd/invalid
Type: error
_Description: Invalid username or password
 Neither the SASL rinputd user name nor the password can be empty.
 Please correct them.
 
--- rinputd.old/debian/templates	2010-04-28 22:27:59.571513752 +0200
+++ rinputd/debian/templates	2010-05-02 14:22:55.463283235 +0200
@@ -1,24 +1,21 @@
-Template: rinputd/about
-Type: text
-_Description: Configure the rinputd sasl username and password
- The following two prompts will help you set up a new sasl user account and
- password. This allows for remote access to this computer.
-
 Template: rinputd/username
 Type: string
 Default: rinput
-_Description: Username:
- This is the user account name for the SASL rinputd login. This has no bearing
+_Description: SASL rinputd user name:
+ Please enter the user name for the SASL rinputd login. This has no bearing
  on the local login, and will not create a local user account, nor conflict
  with the local user namespace.
 
 Template: rinputd/passwd
 Type: password
-_Description: Password:
- Password for the rinputd sasl user account. This password is not related to
+_Description: SASL rinputd password:
+ Pleas enter the password for the rinputd sasl user account. This password is not related to
  shell level login, but will allow control of the keyboard and mouse through
  the rinputd daemon.
 
 Template: rinputd/invalid
-Type: text
-_Description: Error: Invalid username or password
+Type: error
+_Description: Invalid username or password
+ Neither the SASL rinputd user name nor the password can be empty.
+ Please correct them.
+ 
--- rinputd.old/debian/control	2010-04-28 22:27:59.571513752 +0200
+++ rinputd/debian/control	2010-05-02 14:24:20.283271755 +0200
@@ -12,8 +12,8 @@
 Architecture: i386 ia64 alpha amd64 armel hppa mips mipsel powerpc s390 sparc
 Depends: sasl2-bin, ${shlibs:Depends}, ${misc:Depends}
 Conflicts: rinputd
-Description: A server daemon for receiving user input events
- rinputd is a server daemon which listens for remote input clients. Clients
+Description: server daemon for receiving user input events
+ This package provides a server daemon which listens for remote input clients. Clients
  connect over a secure SSL socket and authenticate with the server through the
  Cyrus SASL password database /etc/sasldb2. The client may then initialize an
  input device through the uinput user input event interface. After
@@ -26,8 +26,8 @@
 Priority: extra
 Depends: rinputd (= ${binary:Version}), ${misc:Depends}
 Conflicts: rinputd-dbg
-Description: A server daemon for receiving user input events
- rinputd is a server daemon which listens for remote input clients. Clients
+Description: server daemon for receiving user input events - debug symbols
+ This package provides a server daemon which listens for remote input clients. Clients
  connect over a secure SSL socket and authenticate with the server through the
  Cyrus SASL password database /etc/sasldb2. The client may then initialize an
  input device through the uinput user input event interface. After
@@ -41,8 +41,8 @@
 Architecture: all
 Depends: ${misc:Depends}
 Conflicts: rinput-dev
-Description: A server daemon for receiving user input events
- rinputd is a server daemon which listens for remote input clients. Clients
+Description: server daemon for receiving user input events - development files
+ This package provides a server daemon which listens for remote input clients. Clients
  connect over a secure SSL socket and authenticate with the server through the
  Cyrus SASL password database /etc/sasldb2. The client may then initialize an
  input device through the uinput user input event interface. After
Source: rinputd
Section: net
Priority: optional
Maintainer: Chase Douglas <chase.douglas@ubuntu.com>
Standards-Version: 3.8.4
Build-Depends: cdbs, cmake, debhelper (>= 7), libavahi-client-dev, libavahi-qt4-dev, libqt4-dev, libsasl2-dev, po-debconf
Homepage: https://launchpad.net/rinput
VCS-bzr: http://bazaar.launchpad.net/~chasedouglas/rinput/debian/
VCS-browser: http://bazaar.launchpad.net/~chasedouglas/rinput/debian/files

Package: rinputd
Architecture: i386 ia64 alpha amd64 armel hppa mips mipsel powerpc s390 sparc
Depends: sasl2-bin, ${shlibs:Depends}, ${misc:Depends}
Conflicts: rinputd
Description: server daemon for receiving user input events
 This package provides a server daemon which listens for remote input clients. Clients
 connect over a secure SSL socket and authenticate with the server through the
 Cyrus SASL password database /etc/sasldb2. The client may then initialize an
 input device through the uinput user input event interface. After
 initialization, the client may send input events such as key presses or mouse
 movements.

Package: rinputd-dbg
Section: debug
Architecture: i386 ia64 alpha amd64 armel hppa mips mipsel powerpc s390 sparc
Priority: extra
Depends: rinputd (= ${binary:Version}), ${misc:Depends}
Conflicts: rinputd-dbg
Description: server daemon for receiving user input events - debug symbols
 This package provides a server daemon which listens for remote input clients. Clients
 connect over a secure SSL socket and authenticate with the server through the
 Cyrus SASL password database /etc/sasldb2. The client may then initialize an
 input device through the uinput user input event interface. After
 initialization, the client may send input events such as key presses or mouse
 movements.
 .
 This package contains debug symbols.

Package: rinput-dev
Section: devel
Architecture: all
Depends: ${misc:Depends}
Conflicts: rinput-dev
Description: server daemon for receiving user input events - development files
 This package provides a server daemon which listens for remote input clients. Clients
 connect over a secure SSL socket and authenticate with the server through the
 Cyrus SASL password database /etc/sasldb2. The client may then initialize an
 input device through the uinput user input event interface. After
 initialization, the client may send input events such as key presses or mouse
 movements.
 .
 This package contains a header defining rinput protocol values

Attachment: signature.asc
Description: Digital signature


Reply to: