Re: [RFR] templates://rocksndiamonds/{templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
> @@ -2,10 +2,11 @@
> Type: boolean
> Default: true
> _Description: Download non-free game data?
> - These games require data files that are not available under a free
> - software license and so are not distributable with Debian. This
> - script may automatically download these data files from the net and install
> - them on your system.
> + Games provided in this package require data files that are not available under a free
> + license and so are not distributable along with free software.
> + .
> + These data files may be automatically downloaded from the network and installed
> + on the system.
>
> "These games" triggers the immediate question "what games?"..:-)
>
> s/free software license/free license: licenses are not necessarily for
> software
>
> I tried to avoid "not distributable by Debian" as the license problem
> does not make them redistributable by anything that intends to remain
> free (including derived distros). Not sure that my wording is the
> best, though.
Presumably there's more to it than just being restrictively
licensed, or it would just be a nonfree package. It looks like the
data files don't come with any clear license even to distribute
them.
> Avoid "this script": when the user sees that debconf screen, (s)he is
> not executing any script.
>
> s/net/network
And in fact it's not just from my local network, so we might as well
say "the Internet".
> s/your system/the system: unpersonnalization
Unfortunately "the system" is vague as well as impersonal (the solar
system? The oppressive patriarchal capitalist system?); I would
suggest "and installed locally." So, how about:
The data files required by rocksndiamonds do not have licenses that
would allow them to be distributed as a package. However, they can
be automatically downloaded from the Internet and installed locally.
> Template: rocksndiamonds/select_games
> Type: multiselect
> Choices: Legend Of Zelda, Legend Of Zelda II, Emerald Mine Club, Contributions 1995 - 2006, Snake Bite, BD2K3, BD Dream, Supaplex, DX-Boulderdash
> _Description: Games to download data for:
(Does this need a long description? Are the Choices translatable?)
> Template: rocksndiamonds/util_notfound
> Type: error
> _Description: Missing utilities for download or unpacking
> - The wget, 7-zip, unzip, tar are needed to either download or
> + The wget, 7-zip, unzip, tar utilities are needed to download or
> unpack the game data.
>
> Missing word
Still a missing "and"!
> .
> Some of them are not available on this system.
> You should install them and then reconfigure this package by
> - using 'dpkg-reconfigure rocksndiamonds'.
> + using "dpkg-reconfigure rocksndiamonds".
Don't ask me to install "7-zip" - tell me the package name, p7zip.
How can it be unavailable, though? wget, p7zip, and unzip are hard
dependencies of rocksndiamonds; tar is Essential. I also notice
that rocksndiamonds PRE-Depends on debconf. Is that really
necessary?
Until that's sorted out I would suggest:
Downloading and unpacking the game data requires the packages wget,
p7zip, and unzip, but not all of these are available.
.
You should install them and then reconfigure this package by
using "dpkg-reconfigure rocksndiamonds".
In the package description:
> +Description: arcade-style game
> + This package provides arcade games in the tradition of:
> + * Boulder Dash (C 64);
> + * Emerald Mine (Amiga);
> + * Supaplex (Amiga/PC);
> + * Sokoban (PC);
> + * Legend Of Zelda;
> + * and some others.
Well, the package doesn't exactly provide games, plural; if I'm
understanding this correctly, it provides a game engine (it might be
best to mention the name "Rocks'n'Diamonds", since the packagename
mangles it slightly), and the things it's "in the tradition of" are
all games it can imitate by way of particular downloaded level-sets.
Do we really need to say which antique platform each game came out
for? I mean, we've already made it quite clear that we're talking
about "arcade" games, and most of them surely had versions for more
than one platform... Without that extra complication they hardly
even need bullet-points:
Description: arcade-style game
This package provides the game engine for Rocks'n'Diamonds, an arcade
game in the tradition of "Boulder Dash", "Emerald Mine", "Supaplex",
"Sokoban", "Legend Of Zelda", etcetera. Game levels emulating all of
these can be downloaded from ArtSoft.org.
Unfortunately when I go to look at the licenses I find that
http://artsoft.org/ has been 404ing for the past fortnight, which
may make this whole exercise academic.
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- ../rocksndiamonds-3.2.6.1+dfsg1.pristine/debian/templates 2009-08-02 18:45:18.000000000 +0100
+++ debian/templates 2009-08-10 12:37:46.000000000 +0100
@@ -2,10 +2,9 @@
Type: boolean
Default: true
_Description: Download non-free game data?
- These games require data files that are not available under a free
- software license and so are not distributable with Debian. This
- script may automatically download these data files from the net and install
- them on your system.
+ The data files required by rocksndiamonds do not have licenses that
+ would allow them to be distributed as a package. However, they can
+ be automatically downloaded from the Internet and installed locally.
Template: rocksndiamonds/select_games
Type: multiselect
@@ -15,15 +14,14 @@
Template: rocksndiamonds/util_notfound
Type: error
_Description: Missing utilities for download or unpacking
- The wget, 7-zip, unzip, tar are needed to either download or
- unpack the game data.
+ Downloading and unpacking the game data requires the packages
+ wget, p7zip, and unzip, but not all of these are available.
.
- Some of them are not available on this system.
You should install them and then reconfigure this package by
- using 'dpkg-reconfigure rocksndiamonds'.
+ using "dpkg-reconfigure rocksndiamonds".
Template: rocksndiamonds/error_download
Type: error
_Description: Cannot download required resources
- When script tried to download one of choosen resources downloading
- error occured. Please check Your network connection or retry later on.
+ An error occurred while downloading game data. You should check
+ the network connection and settings and retry later on.
--- ../rocksndiamonds-3.2.6.1+dfsg1.pristine/debian/control 2009-08-02 18:45:18.000000000 +0100
+++ debian/control 2009-08-10 12:43:18.000000000 +0100
@@ -18,13 +18,9 @@
Conflicts: rocksndiamonds-data, rocksndiamonds-zelda, rocks-n-diamonds
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends},
- perl-modules, p7zip, wget, unzip
-Description: Arcade style game
- Arcade game for Unix, Mac OS X, Windows and DOS in the tradition of:
- * "Boulder Dash" (C 64)
- * "Emerald Mine" (Amiga)
- * "Supaplex" (Amiga/PC)
- * "Sokoban" (PC)
- * "Legend Of Zelda"
- etc
-
+ perl-modules, p7zip, wget, unzip
+Description: arcade-style game
+ This package provides the game engine for Rocks'n'Diamonds, an arcade
+ game in the tradition of "Boulder Dash", "Emerald Mine", "Supaplex",
+ "Sokoban", "Legend Of Zelda", etcetera. Game levels emulating all of
+ these can be downloaded from ArtSoft.org.
Template: rocksndiamonds/begin
Type: boolean
Default: true
_Description: Download non-free game data?
The data files required by rocksndiamonds do not have licenses that
would allow them to be distributed as a package. However, they can
be automatically downloaded from the Internet and installed locally.
Template: rocksndiamonds/select_games
Type: multiselect
Choices: Legend Of Zelda, Legend Of Zelda II, Emerald Mine Club, Contributions 1995 - 2006, Snake Bite, BD2K3, BD Dream, Supaplex, DX-Boulderdash
_Description: Games to download data for:
Template: rocksndiamonds/util_notfound
Type: error
_Description: Missing utilities for download or unpacking
Downloading and unpacking the game data requires the packages
wget, p7zip, and unzip, but not all of these are available.
.
You should install them and then reconfigure this package by
using "dpkg-reconfigure rocksndiamonds".
Template: rocksndiamonds/error_download
Type: error
_Description: Cannot download required resources
An error occurred while downloading game data. You should check
the network connection and settings and retry later on.
Source: rocksndiamonds
Section: contrib/games
Priority: extra
Uploaders: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Maintainer: Dmitry E. Oboukhov <unera@debian.org>
Build-Depends: debhelper (>= 5), dpatch, po-debconf,
libsdl1.2-dev (>= 1.2),
libsdl-image1.2-dev (>= 1.2),
libsdl-mixer1.2-dev (>= 1.2),
libsdl-net1.2-dev (>= 1.2.7)
Standards-Version: 3.8.2
Homepage: http://artsoft.org
VCS-Browser: http://git.debian.org/?p=collab-maint/rocksndiamonds.git;a=summary
VCS-Git: git://git.debian.org/collab-maint/rocksndiamonds.git
Package: rocksndiamonds
Pre-Depends: debconf (>= 0.5) | debconf-2.0
Conflicts: rocksndiamonds-data, rocksndiamonds-zelda, rocks-n-diamonds
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends},
perl-modules, p7zip, wget, unzip
Description: arcade-style game
This package provides the game engine for Rocks'n'Diamonds, an arcade
game in the tradition of "Boulder Dash", "Emerald Mine", "Supaplex",
"Sokoban", "Legend Of Zelda", etcetera. Game levels emulating all of
these can be downloaded from ArtSoft.org.
Reply to: