Please find, for review, the debconf templates and packages descriptions for the rocksndiamonds source package.
This review will last from Monday, August 10, 2009 to Thursday, August 20, 2009.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- rocksndiamonds.old/debian/templates 2009-08-02 19:27:50.405579403 +0200
+++ rocksndiamonds/debian/templates 2009-08-10 08:38:01.445058292 +0200
@@ -2,10 +2,11 @@
Type: boolean
Default: true
_Description: Download non-free game data?
- These games require data files that are not available under a free
- software license and so are not distributable with Debian. This
- script may automatically download these data files from the net and install
- them on your system.
+ Games provided in this package require data files that are not available under a free
+ license and so are not distributable along with free software.
+ .
+ These data files may be automatically downloaded from the network and installed
+ on the system.
"These games" triggers the immediate question "what games?"..:-)
s/free software license/free license: licenses are not necessarily for
software
I tried to avoid "not distributable by Debian" as the license problem
does not make them redistributable by anything that intends to remain
free (including derived distros). Not sure that my wording is the
best, though.
Avoid "this script": when the user sees that debconf screen, (s)he is
not executing any script.
s/net/network
s/your system/the system: unpersonnalization
Template: rocksndiamonds/select_games
Type: multiselect
@@ -15,15 +16,15 @@
Template: rocksndiamonds/util_notfound
Type: error
_Description: Missing utilities for download or unpacking
- The wget, 7-zip, unzip, tar are needed to either download or
+ The wget, 7-zip, unzip, tar utilities are needed to download or
unpack the game data.
Missing word
.
Some of them are not available on this system.
You should install them and then reconfigure this package by
- using 'dpkg-reconfigure rocksndiamonds'.
+ using "dpkg-reconfigure rocksndiamonds".
Standard quotes
Template: rocksndiamonds/error_download
Type: error
_Description: Cannot download required resources
- When script tried to download one of choosen resources downloading
- error occured. Please check Your network connection or retry later on.
+ An error occurred while downloading game data. You should check
+ the network connection and settings and retry later on.
s/en_RU/en_FR...:-)
--- rocksndiamonds.old/debian/control 2009-08-02 19:27:50.405579403 +0200
+++ rocksndiamonds/debian/control 2009-08-06 08:13:41.904205047 +0200
@@ -19,12 +19,12 @@
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends},
perl-modules, p7zip, wget, unzip
-Description: Arcade style game
- Arcade game for Unix, Mac OS X, Windows and DOS in the tradition of:
- * "Boulder Dash" (C 64)
- * "Emerald Mine" (Amiga)
- * "Supaplex" (Amiga/PC)
- * "Sokoban" (PC)
- * "Legend Of Zelda"
- etc
+Description: arcade-style game
+ This package provides arcade games in the tradition of:
+ * Boulder Dash (C 64);
+ * Emerald Mine (Amiga);
+ * Supaplex (Amiga/PC);
+ * Sokoban (PC);
+ * Legend Of Zelda;
+ * and some others.
Use the standard "This package provides" in order to have a complete
sentence. Drop he mention of operating systems as the package is meant
for Debian and I doubt we have DOSDebian..:)
I don't think we need to quote the games names.
--
Template: rocksndiamonds/begin Type: boolean Default: true _Description: Download non-free game data? Games provided in this package require data files that are not available under a free license and so are not distributable along with free software. . These data files may be automatically downloaded from the network and installed on the system. Template: rocksndiamonds/select_games Type: multiselect Choices: Legend Of Zelda, Legend Of Zelda II, Emerald Mine Club, Contributions 1995 - 2006, Snake Bite, BD2K3, BD Dream, Supaplex, DX-Boulderdash _Description: Games to download data for: Template: rocksndiamonds/util_notfound Type: error _Description: Missing utilities for download or unpacking The wget, 7-zip, unzip, tar utilities are needed to download or unpack the game data. . Some of them are not available on this system. You should install them and then reconfigure this package by using "dpkg-reconfigure rocksndiamonds". Template: rocksndiamonds/error_download Type: error _Description: Cannot download required resources An error occurred while downloading game data. You should check the network connection and settings and retry later on.
--- rocksndiamonds.old/debian/templates 2009-08-02 19:27:50.405579403 +0200
+++ rocksndiamonds/debian/templates 2009-08-10 08:38:01.445058292 +0200
@@ -2,10 +2,11 @@
Type: boolean
Default: true
_Description: Download non-free game data?
- These games require data files that are not available under a free
- software license and so are not distributable with Debian. This
- script may automatically download these data files from the net and install
- them on your system.
+ Games provided in this package require data files that are not available under a free
+ license and so are not distributable along with free software.
+ .
+ These data files may be automatically downloaded from the network and installed
+ on the system.
Template: rocksndiamonds/select_games
Type: multiselect
@@ -15,15 +16,15 @@
Template: rocksndiamonds/util_notfound
Type: error
_Description: Missing utilities for download or unpacking
- The wget, 7-zip, unzip, tar are needed to either download or
+ The wget, 7-zip, unzip, tar utilities are needed to download or
unpack the game data.
.
Some of them are not available on this system.
You should install them and then reconfigure this package by
- using 'dpkg-reconfigure rocksndiamonds'.
+ using "dpkg-reconfigure rocksndiamonds".
Template: rocksndiamonds/error_download
Type: error
_Description: Cannot download required resources
- When script tried to download one of choosen resources downloading
- error occured. Please check Your network connection or retry later on.
+ An error occurred while downloading game data. You should check
+ the network connection and settings and retry later on.
--- rocksndiamonds.old/debian/control 2009-08-02 19:27:50.405579403 +0200
+++ rocksndiamonds/debian/control 2009-08-06 08:13:41.904205047 +0200
@@ -19,12 +19,12 @@
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends},
perl-modules, p7zip, wget, unzip
-Description: Arcade style game
- Arcade game for Unix, Mac OS X, Windows and DOS in the tradition of:
- * "Boulder Dash" (C 64)
- * "Emerald Mine" (Amiga)
- * "Supaplex" (Amiga/PC)
- * "Sokoban" (PC)
- * "Legend Of Zelda"
- etc
+Description: arcade-style game
+ This package provides arcade games in the tradition of:
+ * Boulder Dash (C 64);
+ * Emerald Mine (Amiga);
+ * Supaplex (Amiga/PC);
+ * Sokoban (PC);
+ * Legend Of Zelda;
+ * and some others.
Source: rocksndiamonds
Section: contrib/games
Priority: extra
Uploaders: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Maintainer: Dmitry E. Oboukhov <unera@debian.org>
Build-Depends: debhelper (>= 5), dpatch, po-debconf,
libsdl1.2-dev (>= 1.2),
libsdl-image1.2-dev (>= 1.2),
libsdl-mixer1.2-dev (>= 1.2),
libsdl-net1.2-dev (>= 1.2.7)
Standards-Version: 3.8.2
Homepage: http://artsoft.org
VCS-Browser: http://git.debian.org/?p=collab-maint/rocksndiamonds.git;a=summary
VCS-Git: git://git.debian.org/collab-maint/rocksndiamonds.git
Package: rocksndiamonds
Pre-Depends: debconf (>= 0.5) | debconf-2.0
Conflicts: rocksndiamonds-data, rocksndiamonds-zelda, rocks-n-diamonds
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends},
perl-modules, p7zip, wget, unzip
Description: arcade-style game
This package provides arcade games in the tradition of:
* Boulder Dash (C 64);
* Emerald Mine (Amiga);
* Supaplex (Amiga/PC);
* Sokoban (PC);
* Legend Of Zelda;
* and some others.
Attachment:
signature.asc
Description: Digital signature