[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://postgrey/{postgrey.templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

Incorporating comments from Adrian von Bidder.

>  Template: postgrey/1.32-3_changeport
> + Postgrey is now listening to port 10023 and not 60000. That will
> + bring the software behavior closer to the default upstream settings.

    Postgrey now listens on port 10023 (rather than 60000), which
    brings its behavior closer to the default upstream settings.

Putting 6000 in parentheses should reduce the risk of careless
readers remembering it backwards.

> + You will need to adjust postgrey's
>   configuration (usually /etc/postfix/main.cf) accordingly.         

That's not exactly _postgrey's_... evade the issue:

    You will need to adjust its configuration (usually in
    /etc/postfix/main.cf) accordingly.

>  Description: greylisting implementation for Postfix
> - A policy server for Postfix implementing greylisting.
> + This package provides a policy server for Postfix, that implements "greylisting".
                                          for Postfix to implement
 
> + Greylisting is a spam filtering method that first rejects email coming
> + from external servers on the first try. It is based on the assumption that
> + most spammers do not retry to send their junk
>   whereas almost all normal mail servers do.

Once we start qualifying s/most/many/ it's not really an assumption.
How about trimming it to:

    Greylisting is a spam filtering method that rejects email from external
    servers on the first try. Spammers don't usually retry sending their
    messages, whereas legitimate mail servers do.

>   While Postgrey is designed for the use with Postfix, it can also be used
                                   XXX
> - with Exim.
> + with Exim or other mail transfer agents.

Reverting this.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- ../postgrey.pristine/debian/postgrey.templates	2009-03-02 12:08:22.000000000 +0000
+++ debian/postgrey.templates	2009-03-06 14:09:53.000000000 +0000
@@ -1,6 +1,8 @@
 Template: postgrey/1.32-3_changeport
 Type: note
 _Description: Default TCP port change
- Postgrey is now listening to port 10023 and not 60000.  The latter was an
- unnecessary Debian specific modification.  You will need to adjust your
- configuration (usually /etc/postfix/main.cf) accordingly.
+ Postgrey is now listening on port 10023 (rather than 60000), which
+ brings its behavior closer to the default upstream settings.
+ .
+ You will need to adjust its configuration (usually in
+ /etc/postfix/main.cf) accordingly.
--- ../postgrey.pristine/debian/control	2009-03-02 12:08:25.000000000 +0000
+++ debian/control	2009-03-06 14:06:08.000000000 +0000
@@ -15,11 +15,11 @@
 Recommends: libdigest-sha1-perl, libnet-rblclient-perl, libparse-syslog-perl,
  postfix
 Description: greylisting implementation for Postfix
- A policy server for Postfix implementing greylisting.
+ This package provides a policy server for Postfix to implement "greylisting".
  .
- Greylisting means that you reject email from a server on the first try,
- using the fact that most spammers do not retry to send their email,
- whereas almost all normal mail servers do.
+ Greylisting is a spam filtering method that rejects email from external
+ servers on the first try. Spammers don't usually retry sending their
+ messages, whereas legitimate mail servers do.
  .
- While Postgrey is designed for the use with Postfix, it can also be used
+ While Postgrey is designed for use with Postfix, it can also be used
  with Exim.
Template: postgrey/1.32-3_changeport
Type: note
_Description: Default TCP port change
 Postgrey is now listening on port 10023 (rather than 60000), which
 brings its behavior closer to the default upstream settings.
 .
 You will need to adjust its configuration (usually in
 /etc/postfix/main.cf) accordingly.
Source: postgrey
Section: mail
Priority: optional
Maintainer: Adrian von Bidder <cmot@debian.org>
Build-Depends: debhelper (>= 4.1.46), po-debconf
Build-Depends-Indep: quilt
Standards-Version: 3.8.0
Homepage: http://postgrey.schweikert.ch/

Package: postgrey
Architecture: all
Depends: adduser, debconf, libberkeleydb-perl (>= 0.23-2), libnet-dns-perl,
 libnet-server-perl (>= 0.87), perl, ucf (>= 0.28)
Conflicts: libsys-syslog-perl (<< 0.21)
Recommends: libdigest-sha1-perl, libnet-rblclient-perl, libparse-syslog-perl,
 postfix
Description: greylisting implementation for Postfix
 This package provides a policy server for Postfix to implement "greylisting".
 .
 Greylisting is a spam filtering method that rejects email from external
 servers on the first try. Spammers don't usually retry sending their
 messages, whereas legitimate mail servers do.
 .
 While Postgrey is designed for use with Postfix, it can also be used
 with Exim.

Reply to: