[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://vsftpd/{vsftpd.templates}



Please find, for review, the debconf templates and packages descriptions for the vsftpd source package.

This review will last from Tuesday, March 03, 2009 to Friday, March 13, 2009.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- vsftpd.old/debian/vsftpd.templates	2009-02-22 08:00:47.293880705 +0100
+++ vsftpd/debian/vsftpd.templates	2009-02-27 07:52:46.863026721 +0100
@@ -1,12 +1,16 @@
 Template: vsftpd/username
 Type: string
-_Default: ftp
-_Description: Dedicated system account for ftp:
- It is required that a unique account is defined which the ftp server can
- use as a totally isolated and unprivileged user.
+Default: ftp

This is non translatable

+_Description: Dedicated system account for the vsftpd FTP daemon:
+ The FTP server must use a dedicated account for its operation so that
+ the system's security is not compromized by running it with the root
+ account privileges.
+ .
+ Please choose that account's username.
 
Be more specific in the synopsis about what we're talking about. That
prompt might come in the middle of a big upgrade/install and the user
might be unaware this is about the vsftpd FTP daemon.

FTP is capitalized as this is a protocol name.


 Template: vsftpd/directory
 Type: string
-_Default: /srv/ftp
-_Description: Directory for ftp root?
- Please specify the directory that should serve as the ftp root.
+Default: /srv/ftp

Non translatable

+_Description: FTP root directory:

No interrogative form in select templates

+ Please specify the directory that will be used as root for the
+ FTP server.

"that should serve as ftp root" seems incorrect and imprecise for me.

--- vsftpd.old/debian/control	2009-02-22 08:00:47.293880705 +0100
+++ vsftpd/debian/control	2009-02-27 07:54:34.712035284 +0100
@@ -15,9 +15,9 @@
 Conflicts: ftp-server
 Replaces: ftp-server
 Provides: ftp-server
-Description: The Very Secure FTP Daemon
- A lightweight, efficient FTP server written from the ground up with
- security in mind.
+Description: security-efficient FTP daemon

avoid over-capitalization and give facts: that server is targeted at security


+ This package provides a lightweight, efficient FTP server written from
+ scratch with security in mind ("vsftp" stands for "The Very Secure FTP Daemon").

"This package provides" helps having a complete sentence....and move
the name explanation there...

  .
- vsftpd supports both anonymous and non-anonymous FTP, PAM authentication,
+ It supports both anonymous and non-anonymous FTP access, PAM authentication,
  bandwidth limiting, and the Linux sendfile() facility.

Avoid leading lowercase.



-- 



Template: vsftpd/username
Type: string
Default: ftp
_Description: Dedicated system account for the vsftpd FTP daemon:
 The FTP server must use a dedicated account for its operation so that
 the system's security is not compromized by running it with the root
 account privileges.
 .
 Please choose that account's username.

Template: vsftpd/directory
Type: string
Default: /srv/ftp
_Description: FTP root directory:
 Please specify the directory that will be used as root for the
 FTP server.
--- vsftpd.old/debian/vsftpd.templates	2009-02-22 08:00:47.293880705 +0100
+++ vsftpd/debian/vsftpd.templates	2009-03-03 22:07:44.272368962 +0100
@@ -1,12 +1,16 @@
 Template: vsftpd/username
 Type: string
-_Default: ftp
-_Description: Dedicated system account for ftp:
- It is required that a unique account is defined which the ftp server can
- use as a totally isolated and unprivileged user.
+Default: ftp
+_Description: Dedicated system account for the vsftpd FTP daemon:
+ The FTP server must use a dedicated account for its operation so that
+ the system's security is not compromized by running it with the root
+ account privileges.
+ .
+ Please choose that account's username.
 
 Template: vsftpd/directory
 Type: string
-_Default: /srv/ftp
-_Description: Directory for ftp root?
- Please specify the directory that should serve as the ftp root.
+Default: /srv/ftp
+_Description: FTP root directory:
+ Please specify the directory that will be used as root for the
+ FTP server.
--- vsftpd.old/debian/control	2009-02-22 08:00:47.293880705 +0100
+++ vsftpd/debian/control	2009-02-27 07:54:34.712035284 +0100
@@ -15,9 +15,9 @@
 Conflicts: ftp-server
 Replaces: ftp-server
 Provides: ftp-server
-Description: The Very Secure FTP Daemon
- A lightweight, efficient FTP server written from the ground up with
- security in mind.
+Description: security-efficient FTP daemon
+ This package provides a lightweight, efficient FTP server written from
+ scratch with security in mind ("vsftp" stands for "The Very Secure FTP Daemon").
  .
- vsftpd supports both anonymous and non-anonymous FTP, PAM authentication,
+ It supports both anonymous and non-anonymous FTP access, PAM authentication,
  bandwidth limiting, and the Linux sendfile() facility.
Source: vsftpd
Section: net
Priority: extra
Maintainer: Daniel Baumann <daniel@debian.org>
Build-Depends: debhelper (>= 7), quilt, libcap2-dev [!kfreebsd-amd64 !kfreebsd-i386 !hurd-i386], libpam0g-dev, libssl-dev, libwrap0-dev, po-debconf
Standards-Version: 3.8.0
Homepage: http://vsftpd.beasts.org/
Vcs-Browser: http://git.debian.net/?p=debian/vsftpd.git
Vcs-Git: git://git.debian.net/git/debian/vsftpd.git

Package: vsftpd
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, libpam-modules, netbase
Recommends: logrotate
Conflicts: ftp-server
Replaces: ftp-server
Provides: ftp-server
Description: security-efficient FTP daemon
 This package provides a lightweight, efficient FTP server written from
 scratch with security in mind ("vsftp" stands for "The Very Secure FTP Daemon").
 .
 It supports both anonymous and non-anonymous FTP access, PAM authentication,
 bandwidth limiting, and the Linux sendfile() facility.

Attachment: signature.asc
Description: Digital signature


Reply to: