[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFC] Add support for shells in the graphical installer



Quoting Jérémy Bobbio (lunar@debian.org):

> This patch adds 6 new translatable debconf templates.  They worth a
> review, for sure. :)

Grmbl...:-)...maybe "some day", I have the hope to have a stable basis
for our translators. These days, they're hunting a moving target...:-)

OK, let's review the new debconf templates.

For dle readers: this is about a new feature in the graphical
installer, allowing to run a shell in a windows.

> +Template: debconf/terminal/gtk/child-exit
> +Type: text
> +_Description: Shell process has exited.

Well, I don't like it..:-)

Not sure what would be the best. Where is this displayed ? Inside a
box ?

I would sugges something like "End of shell process" or "Shell process
terminated".

Whether or not there should be a final dot depends on the context
where this is displayed, imho.

> +Template: test/terminal
> +Type: terminal
> +Description: Feel free to rescue your system.

When is this displayed?


> +
> +Template: debconf/terminal/gtk/child-exit
> +Type: text
> +Description: Shell process has exited.

Ditto....

> -debconf-disconnect /bin/sh || true
> +start-shell di-utils-shell/do-shell /bin/sh || true
> diff --git a/packages/debian-installer-utils/debian/di-utils-shell.templates b/packages/debian-installer-utils/debian/di-utils-shell.templates
> index d84a942..4ff8c49 100644
> --- a/packages/debian-installer-utils/debian/di-utils-shell.templates
> +++ b/packages/debian-installer-utils/debian/di-utils-shell.templates
> @@ -11,6 +11,34 @@ _Description: Interactive shell
>   .
>   Use the "exit" command to return to the installation menu.
>  
> +Template: di-utils-shell/shell-plugin
> +Type: terminal
> +# :sl2:
> +_Description: ${TITLE}

Make this non translatable (removing the leading "_")


> +
> +Template: di-utils-shell/shell-plugin-default-title
> +Type: text
> +# :sl2:
> +_Description: Interactive shell

Seems OK for me.


> +
> +Template: di-utils-shell/terminal-plugin-unavailable
> +Type: error
> +# :sl2:
> +_Description: Terminal plugin unavailable
> + This build of the debian-installer requires the terminal plugin in
> + order to display a shell. Unfortunately, this plugin is currently
> + unavailable.
> + .
> + It should be available after reaching the "Loading additional components"
> + installation step.
> + .
> + ${WORKAROUND}

s/unavailable/not available

The 'terminal' plugin, which is required to open a shell, is not
available. Please load it from the main menu in 'Loading additional
components'.

Template: di-utils-shell/terminal-plugin-unavailable
Type: error
# :sl2:
#flag:translate!:3
_Description: Terminal plugin no available
 The 'terminal' plugin, which is required to open a shell, is not
 available. Please load it from the main menu in 'Loading additional
 components'.
 .
 ${WORKAROUND}


> +
> +Template: di-utils-shell/workaround-gtk
> +Type: text
> +# :sl2:
> +_Description: In the meantime, a shell is still accessible by pressing Ctrl+Alt+F2.  Use Alt+F5 to get back to the installer.
> +

Alternatively, you can open a shell by pression Ctrl+Alt+F2. Use
Alt+F5 to get back to the installer.

(note the single spacing between sentences)

> +Template: rescue/shell/title
> +Type: text
> +# :sl2:
> +_Description: Interactive shell on ${DEVICE}
> +

Seems OK


>  Template: rescue/initrd-shell/intro
>  Type: text
>  # :sl2:
> @@ -96,6 +101,11 @@ _Description: Executing a shell
>   "chroot /target". If you need any other file systems (such as a separate
>   "/usr"), you will have to mount those yourself.
>  
> +Template: rescue/initrd-shell/title
> +Type: text
> +# :sl2:
> +_Description: Interactive shell in the installer environment
> +

Do we really need to specify this?

I'm not sure that the "in the installer environment" is really
meaningful for our users. When we run a shell in the text installer,
it's in the installer's environment and we don't specify it.



Attachment: signature.asc
Description: Digital signature


Reply to: