Please find, for review, the debconf templates and packages descriptions for the lwat source package. Please note that I only focused on recently added debconf templates. We already did such review for lwat in the past but, well, the new templates are IMHO not correct wrt the style recommendations. This review will last from Monday, January 21, 2008 to Thursday, January 31, 2008. Please send reviews as unified diffs (diff -u) against the original files. Comments about your proposed changes will be appreciated. Your review should be sent as an answer to this mail. When appropriate, I will send intermediate requests for review, with "[RFRn]" (n>=2) as a subject tag. When we will reach a consensus, I send a "Last Chance For Comments" mail with "[LCFC]" as a subject tag. Finally, the reviewed templates will be sent to the package maintainer as a bug report, and a mail will be sent to this list with "[BTS]" as a subject tag. Rationale: --- ../lwat.old/debian/templates 2008-01-17 08:27:07.685240081 +0100 +++ debian/templates 2008-01-21 07:54:27.760403083 +0100 @@ -1,8 +1,8 @@ Template: lwat/domain Type: string Default: example.net -_Description: Domain name of your server: - Please enter the domain your server belongs to. +_Description: Server domain name: + Please enter the domain this server belongs to. Unpersonnalize. Template: lwat/uselisgroup Type: boolean @@ -125,7 +125,9 @@ Template: lwat/incompatiblesettings Type: boolean Default: true -_Description: Rewrite smarty template and compile dir? - lwat 0.17 is incompatible with some values set in older configuration files. - So for a correct usage of lwat you'll have to fix these settings. The package will - fix this for you if you enter yes here. +_Description: Fix 'smarty template' and 'compile dir' settings? + Version 0.17 of lwat is incompatible with some values set in older + configuration files. These settings must be fixed for lwat to work + properly. + . + Please choose whether these settings should be fixed automatically. Avoid beginning a sentence with a lowercase letter. Avoid "if you enter yes here" which makes reference to a specific interface. More neutral wording. --
Template: lwat/domain Type: string Default: example.net _Description: Server domain name: Please enter the domain this server belongs to. Template: shared/ldapns/ldap-server Type: string Default: ldap _Description: LDAP server host: Please enter the LDAP host which lwat will connect to. Template: shared/ldapns/base-dn Type: string Default: dc=example,dc=net _Description: LDAP DN base: Please enter the "Distinguished Name" (DN) of the LDAP base where all groups, people, machines, etc. are listed. Template: lwat/uselisgroup Type: boolean Default: true _Description: Should lwat use lisGroups? Debian Edu/Skolelinux uses a private schema called lisGroup to differentiate between various group types. You should choose this option if you are testing lwat on an old Skolelinux server, and still want to be able to use the webmin module wlus. . If you do not choose this option, the AuthGroup setting will be used to create a groupOfMembers. Template: lwat/homedirlocation Type: string Default: /home _Description: Location of users' home directories: Please enter the path where the personal (home) directories of all users are stored. Template: lwat/groupprefix Type: string Default: ou=Group _Description: Prefix for groups on the LDAP server: Please enter the prefix under which the groups information is stored. . Do not include the DN prefix in this setting. It will be automatically added in the generated configuration file. Template: lwat/authprefix Type: string Default: ou=AuthGroup _Description: Prefix for authorization groups on the LDAP server: Please enter the prefix under which the authorization groups information is stored. . Do not include the DN prefix in this setting. It will be automatically added in the generated configuration file. Template: lwat/hostprefix Type: string Default: ou=Hosts _Description: Prefix for hosts on the LDAP server: Please enter the prefix under which the hosts information is stored. . Do not include the DN prefix in this setting. It will be automatically added in the generated configuration file. Template: lwat/netgroupprefix Type: string Default: ou=Netgroup _Description: Prefix for netgroups on the LDAP server: Please enter the prefix under which the netgroups information is stored. . Do not include the DN prefix in this setting. It will be automatically added in the generated configuration file. Template: lwat/minPwLength Type: string Default: 5 _Description: Minimum length of the password for users: Please choose the minimum length for users' passwords. . By default, lwat will autogenerate 8 characters long passwords. Template: lwat/minPwNumber Type: string Default: 1 _Description: Minimum number of digits (characters 0-9) in passwords: Please enter the minimum number of characters in the 0-9 range that will be mandatory in users' passwords. Template: lwat/minPwUpper Type: string Default: 1 _Description: Minimum number of uppercase letters in passwords: Please enter the minimum number of uppercase letters that will be mandatory in users' passwords. Template: lwat/minPwLower Type: string Default: 1 _Description: Minimum number of lowercase letters in passwords: Please enter the minimum number of lowercase letters that will be mandatory in users' passwords. Template: lwat/allowPwSet Type: boolean Default: false _Description: Authorize admins to choose users' passwords? When setting a new password, lwat normally generates a reasonably safe password. Choosing this option will allow administrators to choose the password themselves. Template: lwat/templates Type: select __Choices: None, user/admin, educational institution, old debian-edu/skolelinux Default: user/admin _Description: User account creation template: Lwat uses templates for creating user accounts, to make sure that home directories are placed in the right locations, users are member of the correct groups, etc. Template: lwat/incompatiblesettings Type: boolean Default: true _Description: Fix 'smarty template' and 'compile dir' settings? Version 0.17 of lwat is incompatible with some values set in older configuration files. These settings must be fixed for lwat to work properly. . Please choose whether these settings should be fixed automatically.
--- lwat.old/debian/templates 2008-01-17 08:27:07.685240081 +0100 +++ lwat/debian/templates 2008-01-21 07:56:03.644403004 +0100 @@ -1,8 +1,8 @@ Template: lwat/domain Type: string Default: example.net -_Description: Domain name of your server: - Please enter the domain your server belongs to. +_Description: Server domain name: + Please enter the domain this server belongs to. Template: shared/ldapns/ldap-server Type: string @@ -15,7 +15,7 @@ Default: dc=example,dc=net _Description: LDAP DN base: Please enter the "Distinguished Name" (DN) of the LDAP base where all - groups, people, machines, etc. are located. + groups, people, machines, etc. are listed. Template: lwat/uselisgroup Type: boolean @@ -125,7 +125,9 @@ Template: lwat/incompatiblesettings Type: boolean Default: true -_Description: Rewrite smarty template and compile dir? - lwat 0.17 is incompatible with some values set in older configuration files. - So for a correct usage of lwat you'll have to fix these settings. The package will - fix this for you if you enter yes here. +_Description: Fix 'smarty template' and 'compile dir' settings? + Version 0.17 of lwat is incompatible with some values set in older + configuration files. These settings must be fixed for lwat to work + properly. + . + Please choose whether these settings should be fixed automatically.
Source: lwat Section: misc Priority: optional Maintainer: Patrick Winnertz <winnie@debian.org> Uploaders: Finn-Arne Johansen <faj@bzz.no> Standards-Version: 3.7.3 Build-Depends: debhelper (>= 5), po-debconf, smarty-gettext Homepage: http://bzz.no/lwat Package: lwat Architecture: all Depends: debconf | debconf-2.0, libapache2-mod-php5, php5-ldap, php5, php5-cli, apache2, smarty-gettext Suggests: wget Description: LDAP Web-based Administration Tool Lwat is an web based administration tool which aims to provide a fully functional administration tool for user-, host-, group-, and netgroup administration.
Attachment:
signature.asc
Description: Digital signature